Skip to content

Render: an unfilled shape's glow follows its line - #225

Merged
h-a-n-a-s-h-i merged 1 commit into
storytold:mainfrom
xmaks82:glow-unfilled-outline
Oct 14, 2026
Merged

h-a-n-a-s-h-i merged 1 commit into
storytold:mainfrom
xmaks82:glow-unfilled-outline

Conversation

@xmaks82

@xmaks82 xmaks82 commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

A glow always filled the shape's whole silhouette (effects_below), so a frame with <a:noFill/>, a thin line and <a:glow> — a rounded-rectangle border with a soft glow, common in corporate decks — came out as a solid tinted panel. PowerPoint glows such a shape along its outline only (the glow radius on both sides of the line) and leaves the inside clear. Filled shapes and pictures are unchanged.

Checked against PowerPoint's own PDF export (COM SaveAs ppSaveAsPDF) of 31 real decks, 597 slides, by mean per-pixel difference: the affected slides go from ~29 to ~4 (of 255).

Test: glow_of_an_unfilled_shape_follows_its_line (fails before, passes after). cargo test --workspace and clippy -D warnings pass.

🤖 Generated with Claude Code

@xmaks82
xmaks82 force-pushed the glow-unfilled-outline branch from 8ac6dc2 to cff515c Compare October 14, 2026 18:43
A glow always filled the shape's whole silhouette, so a frame with no fill
(a rounded-rectangle border with a soft glow, common in corporate decks)
came out as a solid tinted panel over the slide. PowerPoint glows such a
shape along its outline only and leaves the inside clear; a filled shape's
or a picture's glow is unchanged. The line glow uses the same width and
blur as the outline part of a filled shape's glow.

Checked against PowerPoint's own PDF export of 31 real decks (597
slides): 66 slides closer to PowerPoint, none further; the frames' slides
go from a mean pixel difference of ~29 to ~2.5-8 (of 255), and the 90th
percentile over all slides from 12.9 to 10.0.
@xmaks82

xmaks82 commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto current main (0c2c433), adapted to the new shadow/glow code: the glow keeps main's measured width and blur, and only the silhouette fill is skipped when the shape has neither a fill nor a picture, so an outline-only shape glows along its line.

Re-measured against PowerPoint's own PDF export of 31 real decks (597 slides): 66 slides closer to PowerPoint, none further. The frame slides go from a mean pixel difference of ~29 to 2.5-8 (of 255), and the 90th percentile over all slides from 12.9 to 10.0. I also tried a wider line glow (1.6r, 2.0r), and both were slightly worse than main's width. Render tests and clippy pass.

@xmaks82
xmaks82 force-pushed the glow-unfilled-outline branch from cff515c to 8d68b2f Compare October 14, 2026 18:44
h-a-n-a-s-h-i pushed a commit that referenced this pull request Oct 14, 2026
…its line

# Conflicts:
#	crates/render/src/lib.rs
@h-a-n-a-s-h-i
h-a-n-a-s-h-i merged commit 198659a into storytold:main Oct 14, 2026
1 check passed
@echelon

echelon commented Oct 14, 2026

Copy link
Copy Markdown
Member

Thank you for this contribution, @xmaks82! It has landed on main and will ship in the next DeckCraft release.

If you haven't already, please come join us on Discord: https://discord.gg/artcraft

anishguduru pushed a commit to anishguduru/deckcraft that referenced this pull request Oct 16, 2026
…g comment tools (storytold#501)

Picking any comment tool opened the Comments panel whenever no right panel
was open, so closing it was undone by the next tool switch. Now closing
Comments (its close button or the rail icon) is remembered, across restarts,
and comment tools leave it closed until the user opens it again (rail, View
menu, Comments ▸ list, or a Reply action). Switching to or closing another
panel doesn't count. Opening a document with comments still shows them, as
Acrobat does.


Claude-Session: https://claude.ai/code/session_01VNJqS2dEQawHJn1qTRJiKp

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants