Skip to content

Text: typing goes on after Tab in a text box (#78) - #139

Merged
h-a-n-a-s-h-i merged 1 commit into
storytold:mainfrom
alexanderalber:issue-78-tab-in-text
Oct 14, 2026
Merged

h-a-n-a-s-h-i merged 1 commit into
storytold:mainfrom
alexanderalber:issue-78-tab-in-text

Conversation

@alexanderalber

Copy link
Copy Markdown
Contributor

Fixes #78. Also covers the "when you indent to have a sub-element, you are unable to type" part of #93 (the Enter/list-continuation part of #93 is not addressed here).

Cause: the engine already handled Tab correctly (Session::key: a tab character, or Increase List Level at the start of a paragraph). But egui also read Tab as focus navigation. With no widget focused, it gave focus to the first focusable widget (a ribbon control). SlideApp::keyboard only routes keys to the slide while no egui widget has focus, so every key after the Tab went nowhere. The same happened to Tab/Shift+Tab cycling through shapes when not editing.

Fix: when the slide has the keyboard and handles a Tab, keyboard() (which runs before the widgets are laid out) cancels egui's pending focus move via move_focus(FocusDirection::None). Tab navigation inside dialogs and focused text fields is unchanged, because keyboard() returns early in those cases.

cargo xtask ci passes locally.

🤖 Generated with Claude Code

The engine handled Tab (a tab character, or a list level at the start of
a paragraph), but egui also treated it as focus navigation: with no
widget focused it focused the first ribbon widget, and since the slide
only takes keys while nothing is focused, every key after Tab was lost.
When the slide has the keyboard, the keyboard handler now cancels that
focus move.

This also covers the "can't type after indenting" part of #93.

generated with Claude Code
@echelon

echelon commented Oct 14, 2026

Copy link
Copy Markdown
Member

Thank you for this contribution, @alexanderalber! It has landed on main and will ship in the next DeckCraft release.

If you haven't already, please come join us on Discord: https://discord.gg/artcraft

h-a-n-a-s-h-i pushed a commit that referenced this pull request Oct 14, 2026
…alises with

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anishguduru pushed a commit to anishguduru/deckcraft that referenced this pull request Oct 16, 2026
…ld#131) (storytold#139)

* CLI: text exits non-zero when a selected page cannot be read (storytold#131)

printcraft-cli text --page N reported the failure on stderr and still exited 0, so a script checking the status could not tell a failed extraction from a successful one. The failing pages are collected and the command now fails with them named, pinned by a test for the nonexistent-page case and one for a normal extraction.

* Move the text exit-code test to the renamed pdfcraft-cli app

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Mohammed Munzir <Mohammed.Munzir@iga.gov.bh>
Co-authored-by: Brandon Thomas <echelon@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tabbing key in a text box does not allow you to continue adding text to that box

3 participants