Repository navigation
Conversation
Audit DeckCraft's default keys against Microsoft's published PowerPoint shortcut lists (editing and slide show, Windows and Mac): 150 of 192 now work, up from 68. Where the platforms disagree, Session::mac_keys picks the one DeckCraft runs on; Mods gains `control` for Mac Cmd+Control keys. - Punctuation shortcuts now fire from the keyboard (egui's CloseBracket, Period, Equals… match the registry's ], ., =), and shifted symbols map back to their key. - Slides, objects, text editing, views, panes and dialogs: Ctrl+M, Ctrl+Shift+D, Ctrl+G, rotate and resize keys, word/paragraph moves, Ctrl+Enter, promote/demote, slide move, Alt+F5, F6 pane cycling, Ctrl+Shift+Tab, Cmd+1-4, New Comment, Spelling, Equation, Paragraph. - Ctrl+= is Subscript on Windows (Ctrl+Plus zooms); Cmd+Control+= on Mac. - Show: H, Cmd+., pointer hide/show, media play/stop/seek keys. - ui.key on the control channel goes through the UI shortcuts first. - Docs: shortcut audit in ui-parity.md, slideshow-parity, gaps, control-protocol, ROADMAP progress log. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
95341df to
8d96333
Compare
…d recovery beside pdfcraft.exe (storytold#325) * Issue storytold#157: the Windows portable zip keeps settings, logs and recovery beside pdfcraft.exe The portable zip had no portable.txt, and the app had no portable mode: it always wrote %APPDATA%\PdfCraft and %LOCALAPPDATA%\PdfCraft. Now portable.txt (or PdfCraft.portable) beside the executable puts the settings, log files, crash recovery and new digital IDs in PdfCraftData next to it, as PhotoCraft does, and the zip ships portable.txt. An unwritable PdfCraftData falls back to the per-user folders and says so. * Issue storytold#157: update ATTRIBUTION.toml SHA-256 for the translation catalogs this PR changes --------- Co-authored-by: Brandon Thomas <echelon@gmail.com>
FredApps
left a comment
There was a problem hiding this comment.
ReviewerA — source-read COMMENT (not an approval)
I read the head of the diff: keyboard shortcuts match PowerPoint's Windows and Mac lists; the ROADMAP says 150 of 192 shortcuts work (68 before) and adds F6 pane cycling and platform-specific keys, and contributors/people.toml gains the author's entry. Matching the platform's documented shortcuts is the right oracle (they are facts, not code). The risk is conflicts: two commands on one key, shortcuts that collide with the operating system or with text-field editing (Ctrl+B in a text box against bold on a shape), so a test that all bindings are unique per platform and context is the proof. The ROADMAP header and the figure are hand-edited, which is the maintainers' tooling's job. I read the ROADMAP and the first engine hunk. I have not run it, and no exact-head CI result exists for this head. Nothing was run.
I ran nothing and have no exact-head CI result for this PR, so this is not an approval. Where a diff was long I read its code hunks rather than every generated or documentation line.
Status: waiting_author.
Summary
This PR checks DeckCraft's default shortcuts against Microsoft's published lists: "Keyboard shortcuts in PowerPoint" (the Windows and Mac tables) and "Use keyboard shortcuts to deliver PowerPoint presentations". It binds every listed shortcut that already has a feature to run.
docs/ui-parity.md#shortcut-audit.Session::mac_keys, records that platform. Mac Cmd+Control shortcuts get a newMods::controlflag.CloseBracketwhile the registry says]. Bring Forward, the font size keys, superscript and Next Window were affected.keys::key_tokennow normalises the key name.{matches Ctrl+Shift+[.ui.key) and MCP all reach the same key path.ui.keynow handles UI shortcuts first, the same way the keyboard does.Added
Slides and files
Objects
Formatting
Text editing
Views, panes and dialogs
Slide show
.still blanks the screen.Engine changes that support the keys
text.movehas a new target,paraNext.paraStartat the start of a paragraph now goes to the previous one, as Ctrl+Up does.shape.resizeaccepts relativedwanddh, clamped.Modsgainscontrol. The MCP and control-channelmodstakecontrol?.Not changed on purpose
Still missing, by the feature each one waits for
Overlap with open PRs
Show::key. The new show keys inshow.rswill conflict as text and need moving into that function.slides_focusedfor Ctrl+A in the slide pane. This PR'sthumbs_focused(set by F6) is the same idea, and the two should merge into one flag.Contributors
Adds my own
[people.n0mahd]entry tocontributors/people.toml(sync_github_name = true).Test plan
Run on Linux aarch64.
cargo xtask ci: fmt, clippy, tests, assets, layers and wasm.Session::key. They cover the punctuation key names, the platform tables, nudging, rotating and resizing, text keys on each platform, paragraph levels, moving slides, Ctrl+Enter, and Space on media.SlideApp::keyboard, thenmenus::ui_shortcut, thenSession::key. They cover the Windows keys, including the AltGr guard and Ctrl+= as Subscript, the Mac keys, and F6 pane cycling..versus Cmd+..🤖 Generated with Claude Code