Repository navigation
Tables: Draw Table pencil and Table Eraser - #544
Merged
Merged
Conversation
Insert > Table > Draw Table turns on a table pencil. Dragging a box on an empty part of the slide makes a one-cell table. Drawing a line inside a table splits the cells it crosses, across or down, and adds a row or column only where needed, so the cells it doesn't cross stay whole. Table Design > Draw Borders has the pencil and a Table Eraser. A click on a border merges the two cells on either side when together they form a rectangle, and their text is kept. The new table.drawLine and table.eraseLine commands are each one undo step. The grid work is pure (engine/src/drawtable.rs). It rebuilds the table from its anchor cells, so existing merges survive, and it caps the grid at 200 rows and columns. Ribbon big buttons now carry an accessibility label. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
|
Thank you for this contribution, @NikitkaRa! It has landed on If you haven't already, please come join us on Discord: https://discord.gg/artcraft |
anishguduru
pushed a commit
to anishguduru/deckcraft
that referenced
this pull request
Oct 16, 2026
…or takes its scale (storytold#544) * Issue storytold#324: vendor winit 0.30.13 as published The crate as released on crates.io, without its asset files (docs/res/*.svg and examples/data/*.png, AGENTS.md §1). Not used yet: the next commit patches it and adds it to [patch.crates-io]. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Issue storytold#324: on Windows 11, a window dragged to another monitor takes its scale winit 0.30.13 handles WM_DPICHANGED by checking that the new window rect is on the monitor `MonitorFromWindow` names. During a drag that is still the monitor being left, so winit nudged the window back onto it, which sent another WM_DPICHANGED: the window grew and stayed on the wrong monitor at the wrong scale. From Windows 11 (build 22000) on, apply the rect Windows suggests, as winit master does since 488c036a (rust-windowing/winit#4341); no 0.30 release has it. Windows 10 keeps the old adjustment, as on winit master. The vendored copy goes in [patch.crates-io]; a test fails if winit resolves from crates.io again or the vendored copy loses the patch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no issue for this. It fills the parity row Tables › Draw table (P2), which moves from M to P. Pen style, weight and colour for drawn borders are still to come; #540 adds pen settings for the Borders menu.
Summary
table.drawLine {from, to, id?}andtable.eraseLine {at, id?, tol?}, one undo step each.engine/src/drawtable.rs. It rebuilds the table from its anchor cells, so existing merges survive, and handles vertical lines by transposing. It rejects non-finite points, snaps to lines within 4 pt, caps the grid at 200 rows and columns, and never panics.Test plan
cargo xtask cipasses (fmt, clippy, test, assets, layers, wasm).Parity checklist: Tables › Draw table goes M → P, and the summary was regenerated with
cargo xtask parity.