Repository navigation
Commands: an invalid shape id is an error instead of the selection - #97
Merged
Merged
Conversation
A shape id that was present but not a valid id (negative, not an integer, larger than u32) was treated as absent, so commands such as text.set and text.edit silently edited the selected shape instead. id_param now tells three cases apart: absent (the selection fallback is unchanged), valid, and invalid (an error naming the command). arrange, edit (select), inspect, review, table, text and the animation painter pick this up.
h-a-n-a-s-h-i
pushed a commit
that referenced
this pull request
Oct 14, 2026
…ter main's selection.select) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Thank you for this contribution, @mikl0s! It has landed on If you haven't already, please come join us on Discord: https://discord.gg/artcraft |
anishguduru
pushed a commit
to anishguduru/deckcraft
that referenced
this pull request
Oct 16, 2026
…t ship (storytold#97) Its Status line said 38 tools and listed form authoring, redaction tools and MCP page-image resources as planned; 123 tools and all three ship. It now names the areas the tools cover and points to printcraft-cli tools for the current list instead of a count that goes stale, and the MCP section lists the resources/* methods and resource templates. ROADMAP's M13 row said 91 tools. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anishguduru
pushed a commit
to anishguduru/deckcraft
that referenced
this pull request
Oct 16, 2026
Docs: automation README, internal craftrules links, docs/releasing.md (storytold#97, storytold#98, storytold#100)
rlaks5757
added a commit
to DTS-Development/deckcraft
that referenced
this pull request
Nov 13, 2026
fix(host-lock): 찾기 단축키가 브라우저 찾기 창을 함께 열지 않게 한다 (dts-craft storytold#97)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A shape
idthat was present but not a valid id (negative, not an integer, larger than u32) was treated as absent. Commands that fall back to the selection whenidis missing, such astext.setandtext.edit, then silently edited the selected shape instead.Before:
text.set {"id": -1, "text": "x"}returns success and rewrites whichever shape is selected.Fix:
id_paramnow tells three cases apart: absent (the selection fallback is unchanged), valid, and invalid (an error that names the command). The arrange, edit (edit.select), inspect, review, table and text commands, the commands defined incmd/mod.rs, and the animation painter pick this up, including theid_paramcall inpainter_pick.Tests: new MCP tests
set_text_unknown_id_is_errorandinvalid_id_never_falls_back_to_selection.cargo test -p deckcraft-mcp --libruns 6 tests, 4 pass and 2 fail.deckcraft-engine42 passed.cargo xtask cipasses on the patched tree.Made with Opus 5.5 high.