Skip to content

UI: Date and Time dialog inserts a format in one step - #668

Merged
h-a-n-a-s-h-i merged 1 commit into
storytold:mainfrom
NikitkaRa:cursor/date-time-dialog-d175
Oct 14, 2026
Merged

h-a-n-a-s-h-i merged 1 commit into
storytold:mainfrom
NikitkaRa:cursor/date-time-dialog-d175

Conversation

@NikitkaRa

Copy link
Copy Markdown
Contributor

Summary

  • Insert › Date & Time opens a Date and Time dialog; insert.dateTime with no params opens it without editing the slide.
  • Formats datetime1–datetime13 with live samples; languages en-US (default), en-GB, fr-FR, ja-JP, sv-SE (rows needing English month names/AM-PM are hidden for others).
  • Update automatically (default) inserts a field; off inserts plain text.
  • Inserts at the caret, otherwise into the slide's date placeholder (text box if the layout has none), as one undo "Date & Time".
  • Explicit format/update/language apply in the same step; invalid values change nothing.

Test plan

  • cargo fmt --all -- --check, clippy -D warnings
  • cargo test --workspace (except 3 known macOS env font/IME failures); engine lib 80 passed
  • cargo xtask assets, layers, wasm
  • Engine tests: dialog opens with no undo, caret insert is one field/one undo, update off is plain text, bad values rejected, placeholder fallback
  • UI test: OK inserts one field with one undo, Cancel leaves slide alone
  • macOS screenshot of the dialog checked by OCR

Insert › Date & Time opens the format list instead of placing a date
immediately. With no format, update flag or language, insert.dateTime
opens the dialog and does not edit. OK applies one undo: a field when
Update automatically is on, or the shown text when it is off.

Co-authored-by: Cursor <cursoragent@cursor.com>
@h-a-n-a-s-h-i
h-a-n-a-s-h-i merged commit 18be662 into storytold:main Oct 14, 2026
h-a-n-a-s-h-i pushed a commit that referenced this pull request Oct 14, 2026
#610 #613 #617 #621 #623 #627 #634 #557 #689 #668)

# Conflicts:
#	crates/engine/src/tests.rs
#	crates/ui-egui/src/dialogs.rs
@echelon

echelon commented Oct 14, 2026

Copy link
Copy Markdown
Member

Thank you for this contribution, @NikitkaRa! It has landed on main and will ship in the next DeckCraft release.

If you haven't already, please come join us on Discord: https://discord.gg/artcraft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants