Repository navigation
UI: Hyperlink dialog follows the selection - #689
Merged
h-a-n-a-s-h-i merged 1 commit intoOct 14, 2026
Merged
h-a-n-a-s-h-i merged 1 commit into
h-a-n-a-s-h-i merged 1 commit into
Conversation
Insert Hyperlink opened on https:// with an empty ScreenTip, so OK replaced a web address, email, slide link or tip. The dialog now starts from the link it would edit, and leaves actions it cannot edit in place.
Member
|
Thank you for this contribution, @NikitkaRa! It has landed on If you haven't already, please come join us on Discord: https://discord.gg/artcraft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Insert Hyperlink always opened on Web Page, address
https://, and an empty ScreenTip, and OK replaced whatever link was already there. The dialog now starts from the link it would edit, and OK writes that same target back unless the fields were changed.mailto:address, slide in this document, and ScreenTip are filled from the selection: the word under a caret inside a link, a text selection that shares one link, or the click action when every selected shape has the same one.highlightClick.insert.hyperlinkaccepts an optionalhighlightClick(false when omitted). Engine command count stays 226.https://unless a new target is chosen. A caret at a word boundary still inserts a new link.Test plan
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspace, apart from the three known macOS environment failurescargo xtask assets,cargo xtask layers,cargo xtask wasm