Skip to content

UI: Hyperlink dialog follows the selection - #689

Merged
h-a-n-a-s-h-i merged 1 commit into
storytold:mainfrom
NikitkaRa:cursor/hyperlink-dialog-selection-b770
Oct 14, 2026
Merged

h-a-n-a-s-h-i merged 1 commit into
storytold:mainfrom
NikitkaRa:cursor/hyperlink-dialog-selection-b770

Conversation

@NikitkaRa

Copy link
Copy Markdown
Contributor

Summary

Insert Hyperlink always opened on Web Page, address https://, and an empty ScreenTip, and OK replaced whatever link was already there. The dialog now starts from the link it would edit, and OK writes that same target back unless the fields were changed.

Test plan

  • cargo fmt --all -- --check
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace, apart from the three known macOS environment failures
  • cargo xtask assets, cargo xtask layers, cargo xtask wasm
  • macOS UI on the sample deck: web, email, slide, shape-click, and next-slide links open prefilled, and OK keeps them unchanged

Insert Hyperlink opened on https:// with an empty ScreenTip, so OK
replaced a web address, email, slide link or tip. The dialog now
starts from the link it would edit, and leaves actions it cannot
edit in place.
@h-a-n-a-s-h-i
h-a-n-a-s-h-i merged commit e0ec02d into storytold:main Oct 14, 2026
h-a-n-a-s-h-i pushed a commit that referenced this pull request Oct 14, 2026
#610 #613 #617 #621 #623 #627 #634 #557 #689 #668)

# Conflicts:
#	crates/engine/src/tests.rs
#	crates/ui-egui/src/dialogs.rs
@echelon

echelon commented Oct 14, 2026

Copy link
Copy Markdown
Member

Thank you for this contribution, @NikitkaRa! It has landed on main and will ship in the next DeckCraft release.

If you haven't already, please come join us on Discord: https://discord.gg/artcraft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants