Repository navigation
Command palette: one Export… entry that opens the dialog, no path-only duplicate (#79) - #82
Merged
Merged
Conversation
Member
|
Thank you for this contribution, @MarekSpodBiedry! It has landed on If you haven't already, please come join us on Discord: https://discord.gg/artcraft |
3 tasks done
anishguduru
pushed a commit
to anishguduru/deckcraft
that referenced
this pull request
Oct 16, 2026
…-finder macOS: open PDFs from Finder, Open With and the Dock (storytold#73)
anishguduru
pushed a commit
to anishguduru/deckcraft
that referenced
this pull request
Oct 16, 2026
…cked (storytold#536) Japanese forms often name a check box's on state in Shift-JIS (「はい」 is /storytold#82#CD#82#A2). State names were read with from_utf8_lossy, so ticking such a box wrote a different name to /AS and /V, no appearance matched, and the box was drawn with no mark (or not at all). Names now map to text losslessly (forms::name_text / name_bytes: UTF-8 as itself, other bytes and `#` as #XX) wherever states and values are read and written: /V, /DV and /AS, PdfCraft's own state appearances, and FDF import and export, so such values also survive an FDF or XFDF round trip. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Brandon Thomas <echelon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79.
The command palette lists the engine commands and then the UI commands (
UI_COMMANDS). Some labels exist in both lists. For "Export…", the enginefile.exportcomes first and is selected by default. It needs apath, which the palette can't give, so Enter fails withinvalid parameters for `file.export`: missing `path`. The second entry,app.exportDialog, opens the Export dialog.The palette now hides an engine command when a UI command has the same label. Only the dialog entry is left. The same duplicates existed for:
file.open) and Save As… (file.saveAs): they need apathtoo. The File menu and Cmd+O / Cmd+Shift+S already use the dialog commands.insert.audio/insert.video): with nopathordatathey fail the same way.slide.notes): run from the palette with notext, it cleared the current slide's notes. The remaining entry is the Notes pane toggle (view.notes).The engine commands are not changed. They still work through the control API and scripts. Only the palette list changes.
The list is built in a new
palette_itemsfunction so a test can check it. The test checks that "exp" and "export" give one "Export…" entry, and that it isapp.exportDialog. It also checks that each UI command is the only palette entry with its label. Both checks fail without the fix.