Skip to content

UI: Grid Options sets spacing, snap and the on-screen grid - #536

Merged
h-a-n-a-s-h-i merged 1 commit into
storytold:mainfrom
NikitkaRa:cursor/grid-options-d175
Oct 14, 2026
Merged

h-a-n-a-s-h-i merged 1 commit into
storytold:mainfrom
NikitkaRa:cursor/grid-options-d175

Conversation

@NikitkaRa

Copy link
Copy Markdown
Contributor

Summary

  • View ▸ Grid Options, the View ribbon button and view.gridOptions with no fields now open a Grid Options dialog.
  • OK sets the grid spacing (1–288 pt), snap to grid, snap to other objects, and whether gridlines and drawing guides are shown. Cancel keeps the previous settings.
  • The on-screen grid now uses that spacing.
  • Passing those fields to view.gridOptions applies them without opening the dialog.

Test plan

  • View ▸ Grid Options and the View ribbon button open the dialog.
  • OK with "Display grid on screen" draws the grid, and Cancel keeps the previous settings.
  • A spacing of 72 pt draws lines one inch apart, and the guides still cross at the slide centre.
  • view.gridOptions rejects a spacing that is not finite, zero or out of range, and a flag that is not a bool.
  • cargo xtask ci: fmt, clippy, assets, layers and wasm passed. On the Mac, symbol_font_characters_draw_in_the_sym_font fails because Wingdings 2 has the glyph for U+F0DE. This is unrelated to this change.

View › Grid Options sets the grid spacing, snap to grid, snap to
other objects, and whether gridlines and guides are drawn. The
canvas grid follows that spacing.

Co-authored-by: Cursor <cursoragent@cursor.com>
@h-a-n-a-s-h-i
h-a-n-a-s-h-i merged commit 2d4c4e7 into storytold:main Oct 14, 2026
h-a-n-a-s-h-i pushed a commit that referenced this pull request Oct 14, 2026
…st finds its own Spacing

- Turning guides on in Grid Options (#536) now adds the two centre guides to a presentation
  without any, as View › Guides does since #559 stopped drawing fixed centre lines.
- The Grid Options dialog test looked for any "Spacing" label; main's ribbon has Line Spacing
  too, so it looks for "Spacing (pt)".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@echelon

echelon commented Oct 14, 2026

Copy link
Copy Markdown
Member

Thank you for this contribution, @NikitkaRa! It has landed on main and will ship in the next DeckCraft release.

If you haven't already, please come join us on Discord: https://discord.gg/artcraft

h-a-n-a-s-h-i pushed a commit that referenced this pull request Oct 14, 2026
 #630 #637 #536 #559 #519 #506 #549 #556 #525)

# Conflicts:
#	crates/engine/src/cmd/review.rs
#	crates/engine/src/tests.rs
#	crates/ui-egui/src/dialogs.rs
#	crates/ui-egui/src/panes.rs
anishguduru pushed a commit to anishguduru/deckcraft that referenced this pull request Oct 16, 2026
…cked (storytold#536)

Japanese forms often name a check box's on state in Shift-JIS (「はい」 is
/storytold#82#CD#82#A2). State names were read with from_utf8_lossy, so ticking such a
box wrote a different name to /AS and /V, no appearance matched, and the box
was drawn with no mark (or not at all).

Names now map to text losslessly (forms::name_text / name_bytes: UTF-8 as
itself, other bytes and `#` as #XX) wherever states and values are read and
written: /V, /DV and /AS, PdfCraft's own state appearances, and FDF import and
export, so such values also survive an FDF or XFDF round trip.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Brandon Thomas <echelon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants