Repository navigation
UI: Grid Options sets spacing, snap and the on-screen grid - #536
Merged
Merged
Conversation
View › Grid Options sets the grid spacing, snap to grid, snap to other objects, and whether gridlines and guides are drawn. The canvas grid follows that spacing. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks done
h-a-n-a-s-h-i
pushed a commit
that referenced
this pull request
Oct 14, 2026
…st finds its own Spacing - Turning guides on in Grid Options (#536) now adds the two centre guides to a presentation without any, as View › Guides does since #559 stopped drawing fixed centre lines. - The Grid Options dialog test looked for any "Spacing" label; main's ribbon has Line Spacing too, so it looks for "Spacing (pt)". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Thank you for this contribution, @NikitkaRa! It has landed on If you haven't already, please come join us on Discord: https://discord.gg/artcraft |
h-a-n-a-s-h-i
pushed a commit
that referenced
this pull request
Oct 14, 2026
anishguduru
pushed a commit
to anishguduru/deckcraft
that referenced
this pull request
Oct 16, 2026
…cked (storytold#536) Japanese forms often name a check box's on state in Shift-JIS (「はい」 is /storytold#82#CD#82#A2). State names were read with from_utf8_lossy, so ticking such a box wrote a different name to /AS and /V, no appearance matched, and the box was drawn with no mark (or not at all). Names now map to text losslessly (forms::name_text / name_bytes: UTF-8 as itself, other bytes and `#` as #XX) wherever states and values are read and written: /V, /DV and /AS, PdfCraft's own state appearances, and FDF import and export, so such values also survive an FDF or XFDF round trip. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Brandon Thomas <echelon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
view.gridOptionswith no fields now open a Grid Options dialog.view.gridOptionsapplies them without opening the dialog.Test plan
view.gridOptionsrejects a spacing that is not finite, zero or out of range, and a flag that is not a bool.cargo xtask ci: fmt, clippy, assets, layers and wasm passed. On the Mac,symbol_font_characters_draw_in_the_sym_fontfails because Wingdings 2 has the glyph for U+F0DE. This is unrelated to this change.