Repository navigation
Do not draw the selection over the frozen pane when it lies only in the scrolling pane (#198) - #217
Merged
Conversation
…he scrolling pane (storytold#198)
Member
|
Merged — thank you for the contribution! If you haven't already, come join us on the ArtCraft Discord: https://discord.gg/artcraft |
h-a-n-a-s-h-i
pushed a commit
that referenced
this pull request
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #198.
With frozen rows or columns, all four panes are painted in one coordinate system and each pane only clips its own drawing.
paint_selectionran once per pane and drew the whole selection every time, so a selection scrolled under the frozen columns/rows was painted on top of the frozen pane (the stray box in the issue screenshot).What changed (
crates/ui-egui/src/grid.rs,chartview.rs):New helpers on
Geo:range_panes(screen areas of the panes that hold a range) andhidden_under_frozen(cell scrolled entirely under the frozen rows/columns). Sheets without frozen panes behave as before.Not changed: charts, pictures and shapes still float over the frozen panes, and Trace Precedents/Dependents arrows are drawn across them, as before. How objects and arrows anchored across the freeze line should behave is a separate decision.
Tests: four unit tests in
grid.rs(pane_tests) cover the pane overlap check, cells scrolled under the frozen columns, clipping ranges to their panes, and the hidden fill handle.