Repository navigation
Grid: freeze panes by dragging the freeze handles (#195) - #309
Merged
Merged
Conversation
Like Excel for the web, a bar in the upper part of the column-header strip and one in the left part of the row-header strip sit on the frozen panes' edges (the corner's edges when nothing is frozen). Dragging one previews the line and, on release, freezes up to the nearest column or row boundary through view.freezePanes; dragging back to the corner unfreezes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Merged — thank you for the contribution! If you haven't already, come join us on the ArtCraft Discord: https://discord.gg/artcraft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #195
Root cause
Freezing panes was only possible through View › Freeze Panes. The issue's screenshot is Excel for the web, which has draggable freeze handles at the top-left of the headers; GridCraft had nothing to drag.
What changed (
crates/ui-egui/src/grid.rs)view.freezePanes {cell}command, so it is undoable and recorded like the menu command. The other direction's freeze is kept. Dragging back to the corner unfreezes that direction; when nothing is left frozen, panes are unfrozen.grid.rs.Tests
crates/ui-egui/tests/freeze_handles.rs, with real pointer drags:cargo test -p gridcraft-ui-egui --lib --test freeze_handles --test header_autofit --test popup_dismissal --test interactioncargo fmt -p gridcraft-ui-egui -- --checkcargo clippy -p gridcraft-ui-egui --all-targets -- -D warningsNot done
topLeftCell). Dropping a handle on a scrolled sheet can therefore freeze more lines than are visible, limited to what fits on screen.view.split) are not part of this.Unverified assumptions (needs confirmation in Excel)
🤖 Generated with Claude Code