Repository navigation
macOS DMG: branded window background and icon layout - #21
Merged
Merged
Conversation
This was referenced Oct 8, 2026
XusBadia
force-pushed
the
dmg-background
branch
3 times, most recently
from
October 8, 2026 15:57
f7ea5ae to
b9f4d3a
Compare
The DMG opened as a plain Finder window. It now shows the app icon's figure on the WordCraft colour, with WordCraft.app and the Applications link side by side. Same approach as PhotoCraft's and VectorCraft's (storytold/photocraft#1201, storytold/vectorcraft#493). - packaging/macos/dmg/: background.svg (source; text outlined, no paper grain, the figure an <image> of assets/app-icon), background.tiff (1x + 2x HiDPI, 16-colour palette, Deflate, sRGB; ~23 KB) and dmg-layout.DS_Store (Finder view settings: window, icon size 128, positions, background). - generate.py writes the TIFF and the layout on any OS, byte-for-byte reproducible, with nothing from the machine that ran it (no paths, users, disk names or volume UUIDs). - package.sh copies them into the staging folder; the image is still built with hdiutil makehybrid. Nothing extra runs in the signing job. - The volume name drops the version: the layout finds the background through an alias that includes the volume name. The DMG file name keeps the version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
XusBadia
force-pushed
the
dmg-background
branch
from
October 9, 2026 05:43
b9f4d3a to
69844b9
Compare
Member
|
Lovely, reproducible DMG window. Byte-for-byte reproducibility and the scrubbed alias are exactly what we want for a committed binary. Merged! We'll check that the background shows up on the next signed and notarized release. Thank you for contributing to WordCraft! If you haven't already, please join our Discord: https://discord.gg/artcraft |
This was referenced Oct 10, 2026
matstrange
added a commit
to matstrange/wordcraft
that referenced
this pull request
Oct 21, 2026
The ids the main document refers to are the ones it names in a relationship attribute (`r:id`, VML's `o:relid`) — the same rule the embedded objects use. The reader has already parsed the main document, so the ids are taken from that tree: no search over the part at all, and no second parse. An id that only appears as text is not a reference. The text names no part, and treating it as one lost the part on save: the relationship was skipped as "already referred to", so its target was carried neither by the element that names it nor as an unmodelled part. The ranked gap list held two rows each for storytold#19, storytold#20 and storytold#21; the stale copies are gone, and the kept rows carry the measured figures. The layout parity table now carries the benchmark's numbers for the word beside a float, and the commit they were measured on. storytold#3411
matstrange
added a commit
to matstrange/wordcraft
that referenced
this pull request
Oct 22, 2026
main moved 553 commits ahead (e05b7fe..8e98636), so the branch no longer merged cleanly. The conflicts were ROADMAP.md, docs/file-format-parity.md, docs/layout-parity.md and docs/gaps.md; the code merged on its own. Each of the four documents carries the branch's change in front of main's, with both sides kept: the status line lists the branch's item first and main's list after it as "previously trivial: ", and the progress log and the revision history take the branch's entry first, then main's. docs/gaps.md also holds the ranked gap table. main carried two rows each for storytold#19, storytold#20 and storytold#21; the branch had already dropped the stale copies, so the table has one row per gap now, and each row keeps both sides' text: main's screen-reader entry in storytold#18, its content-control saving figure and its ODT table column widths in storytold#19 and storytold#20, and the branch's storytold#3411 and storytold#3412 figures in storytold#20. Co-Authored-By: opencode <noreply@opencode.ai>
daghantektepe
added a commit
to daghantektepe/wordcraft
that referenced
this pull request
Nov 6, 2026
…ound and icon layout tamamlandı
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The macOS DMG opened as a plain white Finder window. It now opens like this:
The icon's figure as a cover on the WordCraft colour field, WordCraft.app and the
Applicationslink side by side on Paper, and a small WordCraft-specific touch: the arrow and the mono line under the title come from the app's craft. Ink, Paper and the app colour only; Inter and JetBrains Mono.How
Same approach as PhotoCraft's and VectorCraft's, which have landed (storytold/photocraft#1201, storytold/vectorcraft#493):
packaging/macos/dmg/background.svg: the source. Its text is outlined, so rendering it needs no fonts, and the figure is an<image>of the existing icon inassets/app-icon/.background.tiff: 1x 660×400 + 2x 1320×800 in one HiDPI TIFF (16-colour palette, Deflate, sRGB; 23 KB). No paper grain: noise doesn't compress, and this keeps the binary small.dmg-layout.DS_Store: Finder's view settings (window 660×400 content, icon size 128, WordCraft.app at (326, 205), Applications at (574, 205), the background). It's named so it isn't mistaken for, or ignored like, a Finder-generated.DS_Store.generate.py: writes both from the SVG on any OS (pip install 'pillow>=12' ds_store==1.3.3 mac_alias==2.2.3, resvg on PATH). The output is byte-for-byte reproducible and carries nothing from the machine that ran it: no paths, users, disk names or volume UUIDs.package.shcopies the TIFF and the layout into the staging folder. The image is still built withhdiutil makehybrid, and nothing extra runs in the signing job.One behaviour change: the volume name drops the version
.DS_Storepoints at the background through an alias that includes the volume name. WithWordCraft <version>Finder kept the window and icon positions but lost the background (tested). So the mounted volume is now calledWordCraft; the DMG file name still carries the version.Tested
package.shsteps (staging folder,makehybrid, UDZO) around a stubWordCraft.appwith the real icon, mounted it and opened it in Finder on macOS: the screenshot above is that DMG.shellcheckclean;cargo xtask assetspasses where the repo has it;generate.pyreproduces the committed files byte for byte (6 runs).Across the suite
Matching PRs for every Crafting App, same layout, each with its own figure and colour:
🤖 Generated with Claude Code