Repository navigation
Mail merge: use Excel and OpenDocument spreadsheets as recipient lists - #341
Merged
echelon merged 2 commits intoOct 11, 2026
Merged
Conversation
vangel76
force-pushed
the
feat/334-spreadsheet-recipients
branch
3 times, most recently
from
October 10, 2026 23:24
eb9666c to
62fca27
Compare
vangel76
force-pushed
the
feat/334-spreadsheet-recipients
branch
from
October 11, 2026 00:05
62fca27 to
47e7ee0
Compare
vangel76
force-pushed
the
feat/334-spreadsheet-recipients
branch
from
October 11, 2026 07:55
47e7ee0 to
d286442
Compare
…told#334) Select Recipients › Use an Existing List… now reads .xlsx, .xlsm and .ods workbooks besides CSV. A new read-only SpreadsheetML / ODF spreadsheet reader in wordcraft-formats lists the sheets and turns one sheet into rows of display strings: shared, inline and rich strings, numbers, booleans, cached formula results, dates and times as ISO 8601 from the cell's number format, sparse cells, ODS value types, repeated rows/columns and covered cells. Zip entries, rows, columns, cells, string lengths and repeat counts are capped, and nothing recurses. mailings.recipients takes "data" (base64) and "sheet" and "headers"; a workbook with several sheets and no sheet answers with the sheet names, and the app shows a Select Table dialog with "First row of data contains column headers". The desktop picker, dropped files and the web inbox route spreadsheets to the recipient list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vangel76
force-pushed
the
feat/334-spreadsheet-recipients
branch
from
October 11, 2026 16:57
d286442 to
bcb960d
Compare
# Conflicts: # ROADMAP.md # crates/ui-egui/src/i18n/ru.tsv # crates/ui-egui/src/i18n/tr.tsv # docs/gaps.md # docs/target-app-parity.md
Member
|
Thanks for the contribution, @vangel76! This is now merged into main. If you haven't already, please come join us on Discord: https://discord.gg/artcraft |
daghantektepe
added a commit
to daghantektepe/wordcraft
that referenced
this pull request
Nov 6, 2026
…l and OpenDocument spreadsheets (storytold#334) tamamlandı
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Select Recipients › Use an Existing List… now opens Excel (
.xlsx,.xlsm) and OpenDocument (.ods) spreadsheets as well as CSV/TSV.crates/formats/src/sheet.rs, new, L2): a read-only reader written from ECMA-376 Part 1 §18 (SpreadsheetML) and OASIS ODF 1.3. It reuses the zip and quick-xml crates the workspace already has. It lists a workbook's sheets (workbook.xml+ rels, or the names of thetable:tableelements incontent.xml; chart sheets are skipped) and reads one sheet into rows of strings:TRUE/FALSE), errors, cached formula results (<v>), sparse cells (r="C5"gaps), out-of-order rows. Merged cells keep only the top-left value.yyyy-mm-dd,yyyy-mm-dd hh:mm[:ss]orhh:mm[:ss]. This covers built-in formats 14–22, 27–36, 45–47 and 50–58, and custom formats withd/y/h/soutside quotes and brackets. I chose ISO because it is locale-neutral and can't be misread. Both the 1900 and the 1904 date systems are handled. Other numbers keep up to 15 significant digits.office:value-typefloat/date/time/boolean/string (percentages and currencies use the cell's displayed text),table:number-columns-repeated/number-rows-repeated, covered cells,text:s/tab/line-break. Annotations are skipped.Column Nand repeated names are numbered (Name,Name 2).mailings.recipientsaccepts{"path"|"data" (base64), "sheet"?: name | number (1 = first), "headers"?: bool}. Files are recognised by extension or by what is inside the zip. If a workbook has several sheets and nosheetis given, the command returns{"sheets": [...], "chooseSheet": true}and loads nothing. CSV loaded from a file also gets the blank/duplicate header clean-up, andheaders: falseworks for every source.Limits (never-crash)
number-rows-repeated="1048553"costs nothing.Not done yet: number formats other than dates (currency, percent, thousands separators) in
.xlsxshow the plain value. No.xls, Access or Outlook sources.Testing
wordcraft-formats: xlsx with shared and rich strings, built-in and custom date formats, a number with float noise, a gap and duplicate/blank headers; ods with repeated rows/columns, covered cells and every value type; hostile files (4 billion repeat counts, a small zip that inflates past the cap, giant cell references, long strings, junk bytes). All are rejected or capped without a panic.wordcraft-engine: a two-sheet workbook asdatareturns the sheet list, then loads by name or number, with and without headers; bad sheet numbers and bad base64 are errors.hostile_params_never_panicpasses.wordcraft-ui-egui: picking a two-sheet workbook opens Select Table, and its answer loads the chosen sheet. The i18n catalog tests pass.cargo fmt,clippy -D warnings(formats, engine, ui-egui, wordcraft) and tests for the touched crates pass.cargo xtask layers,assetsandwasmpass.Fixes #334
🤖 Generated with Claude Code