Repository navigation
Add Estonian interface translation - #294
Merged
Merged
Conversation
Contributor
Author
|
@echelon Could you please review and merge this Estonian interface translation? All six local CI checks passed, including 979 tests. |
A test-only pseudo-language wraps every catalog lookup in ⟦…⟧ marks; a new audit test lays the app out in it (every tab, File page, dialog and pane, the right-click menu, and a hover and a click on every ribbon control, including the Table and Equation tabs) and fails on any visible text outside the marks. The document is drawn as an image, so only interface text is checked; document text, font and style names, shortcuts, icon lettering, contributor handles and command error messages are allowed. What it found, now translated in every language that has the strings: - Right-click menu items (Cut, Paste, Font…, Paragraph…, Link…, New Comment). - Paragraph dialog: the alignment choices showed code values (`left`); the label now sits before the dropdown. - Table Design › Table Style Options checkboxes. - Table Layout › Alignment tooltips showed code values (`topLeft`). - Design › Fonts: the theme's name is translated, its font names are not. - `pt` units, the Insert › Table grid label, the default watermark text, the font dialog's preview sample, and the untitled document's name. - Contributors and Models dialogs: headings, sort and name choices, summary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WtHKQ7wrZm3uBuaG1Ye8po
storytold#303) Insert › Tables › Draw Table and Table Layout › Draw › Draw Table / Eraser. table.draw takes a pen stroke in page points: a rectangle outside a table inserts a one-cell table of that size at the paragraph under its start; a straight vertical or horizontal line inside a table splits the cells it crosses (new grid column or row; untouched cells span it). table.eraser merges the two cells beside the border nearest a point. Each stroke is one undo step. In the app the buttons toggle pen and eraser modes with a live preview, a crosshair with the tool's icon, and Esc to stop; canvas clicks don't move the caret while a tool is on. Splitting through part of a vertically merged cell and erasing beside one are refused with a clear error. Catalog 384/430 -> 387/430. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…storytold#307) Ink strokes are floating freeform shapes: a new Freeform geometry (paths in shape-local coordinates, opacity, and the pen that drew it) on InlineObject::Shape with ShapeKind::Freeform. draw.stroke inserts one anchored to the paragraph under the first point (one undo step; points capped per stroke, strokes capped per page, NaN dropped); draw.erase / draw.eraser with a point deletes the stroke under it; draw.pen, draw.pencil, draw.highlighter, draw.eraser and draw.select set the Draw tab's tool in the session view state; review.hideInk toggles showing ink on screen. The canvas draws a live stroke while a pen is dragged and commits it on release; the eraser deletes strokes it passes over (one undo step per drag); Esc or Select goes back to selecting. Draw tab buttons show the tool in use, with colour and thickness menus; Review gets an Ink group with Hide Ink. Ink renders with round caps and joins on screen and in PDF; highlighters are translucent and behind the text. DOCX writes freeforms as wps:wsp with a:custGeom (moveTo/lnTo) in a wp:anchor and reads them back, along with simple custom-geometry freeforms from other files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ink ported onto main's shared wsp writer (custom geometry, ink names, alpha, round caps also for group members); shape_draws takes main's ShapeEffects. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The ribbon's pressed-state helper is storytold#308's big_toggle; the Draw tab and Review > Hide Ink use it (Hide Ink toggles without params). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tGeom path cap, ink docs - draw.eraser with a point erases through draw.erase: test that it is one undo step (undo/redo) and marks the document dirty. - Render and PDF: a single-point stroke's dot is drawn at the sanitized point, not the raw first one. - DOCX custGeom reading stops once MAX_PATHS paths (subpaths included) are collected, across a:path elements. - docs/file-format-parity.md: ink is saved as custom geometry, not InkML, so Word shows it as a freeform. - widgets test: theme::apply takes an Appearance (storytold#317). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Paragraph dialog: storytold#313's translated alignment combo and pt suffixes moved into main's tabbed dialog (Indents and Spacing tab). The watermark dialog's default text stays English: it is written into the document. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rows in all eight catalogs for the strings storytold#313 now sends through the catalog (cell alignment tooltips, credits columns and summary, theme names, context-menu items, table picker, pt suffix, Document1, the Font dialog sample) and for the Table Style preview's sample table, which the untranslated-text audit flagged after main's table style editor landed. The audit runs headless (no host services: no file pickers or speech) in about 20 s, so it stays enabled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
LANGUAGES grows to 10 on top of the stack. The AGENTS.md section the PR added
("Local build and fork checks") is dropped: it describes one contributor's
setup, not repository rules. Estonian rows for every label main and this
stack added since the catalog was written (clipboard pane, table styles,
Manage Styles, Asian typography, Group, Shape Effects, password protection,
AutoSave reasons, Draw Table, Draw tab ink, storytold#313's interface text); the
stale '➕ New comment' and '📂 Browse…' rows (renamed by storytold#305) are removed,
so et's keys equal es's again.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
, storytold#342 …) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…orytold#327, storytold#342, storytold#363) Same ink-on-rotation port as on fix-301: freeforms draw through shape_draws inside spun groups, DisplayOptions has hide_ink beside revisions, the page cache key hashes both; docx read/mod.rs has embed and freeform. Progress docs start from main's and re-apply storytold#307's rows; one 'Ink' catalog row (main's). Parity regenerated (402/434). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
storytold#313's untranslated-text audit flagged main's new dialog (storytold#327). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Define New Multilevel List and Track Changes Options (storytold#342), rotation (storytold#332), Tabs and Borders and Shading (storytold#327), Columns, Symbol and Field (storytold#335): et keys equal es again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ad is understood It failed once in ~46 runs on a heavily loaded machine and passed 35 straight reruns, so CI shouldn't depend on it yet. Run it with --ignored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Merged — thank you, @henno, for the Estonian interface! While integrating, we dropped the AGENTS.md section and added Estonian rows for everything that landed since; a native-speaker skim of the newer rows would be welcome. If you're not on our Discord yet, come say hi: https://discord.gg/artcraft |
This was referenced Oct 10, 2026
This was referenced Oct 10, 2026
Merged
daghantektepe
added a commit
to daghantektepe/wordcraft
that referenced
this pull request
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WordCraft can now show its interface in Estonian. Select "Eesti" in File → Options → Interface language, use
ui.languagewith{"value":"et"}, or let the automatic setting follow anet-EEsystem locale.et.tsvcatalog for ribbon labels, commands, menus, dialogs, tooltips, status text, Zotero and Read Aloud controls. The catalog uses plain Estonian and count-neutral labels. Product names, placeholders and command IDs stay intact.sync_github_name = true, as requested by the contributor instructions. Add the local build and fork steps to AGENTS.md with the owner's approval.This PR adds an interface translation. Estonian spelling, grammar, document templates and date formats need separate work. Document style names stay as defined by the document, and interface text outside the existing translation system can still appear in English.
Validation: all 25 interface-language tests passed. Rendered and inspected the Home and Review tabs and Options page with
ui_shot, including õ, ä, ö, ü, š and ž. Also rendered and inspected the Table Properties dialog after integrating the current main branch.cargo xtask cipassed all six steps: formatting, Clippy with warnings denied, all 979 tests, asset attribution, dependency layers and WASM checks.