fix: use statvfs directly for disk space to fix VirtioFS 256x inflation #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sysinfo crate's Disks API multiplies block counts by f_bsize instead of f_frsize, inflating reported disk space by 256x on VirtioFS mounts (Docker Desktop) where f_bsize=1MiB but f_frsize=4KiB. This caused the dashboard to show 231 TiB instead of 927 GiB. Replace the sysinfo-based disk_space_for_path with direct libc::statvfs on Unix, correctly using f_frsize for block size calculations. Keep the sysinfo fallback for non-Unix platforms. Co-Authored-By: Claude Opus 4.6 <[email protected]>
The statvfs struct fields (f_blocks, f_bavail, f_frsize) are u32 on macOS but u64 on Linux. The casts are needed for portability but trigger clippy::unnecessary_cast on Linux CI. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12
sysinfocrate's disk space calculation with directlibc::statvfscall on Unixf_frsizeinstead off_bsize, fixing 256x inflation on VirtioFS mounts (Docker Desktop)Test plan
🤖 Generated with Claude Code