Skip to content

fix: use statvfs directly for disk space to fix VirtioFS 256x inflation #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattleaverton wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: use statvfs directly for disk space to fix VirtioFS 256x inflation #10

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc8d0d1
fix: use statvfs directly for disk space to fix VirtioFS inflation
mattleaverton Feb 12, 2026
cc3c4d8
fix: allow clippy unnecessary_cast for cross-platform statvfs fields
mattleaverton Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: allow clippy unnecessary_cast for cross-platform statvfs fields 
The statvfs struct fields (f_blocks, f_bavail, f_frsize) are u32 on
macOS but u64 on Linux. The casts are needed for portability but
trigger clippy::unnecessary_cast on Linux CI.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
  • Loading branch information
@mattleaverton @claude
mattleaverton and claude committed Feb 12, 2026
commit cc3c4d826534721d3d5d01d3ef97e989ad2c78db
1 change: 1 addition & 0 deletions server/src/metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,6 +838,7 @@ fn alpha(dt: f64, window_seconds: f64) -> f64 {
/// counts by f_bsize instead of f_frsize, which inflates values by 256x on
/// VirtioFS mounts (Docker Desktop) where f_bsize=1MiB but f_frsize=4KiB.
#[cfg(unix)]
#[allow(clippy::unnecessary_cast)] // statvfs fields are u32 on macOS, u64 on Linux
fn disk_space_for_path(path: &Path) -> (u64, u64) {
use std::ffi::CString;
use std::os::unix::ffi::OsStrExt;
Expand Down
Loading