Skip to content

#880, make the demo at /#virtual-paging work properly #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amcdnl merged 3 commits into from
Jan 21, 2018
Merged

#880, make the demo at /#virtual-paging work properly #1229

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60cd595
#880, set rowCount to rows.length, to prevent 'Error: query at index …
ivankolev Jan 11, 2018
b3680b3
Merge remote-tracking branch 'upstream-origin/master'
ivankolev Jan 14, 2018
3706e0d
#880, only query the rowHeightsCache when the rowCount is not zero
ivankolev Jan 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/body/body.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ export class DataTableBodyComponent implements OnInit, OnDestroy {
@Input() set rows(val: any[]) {
this._rows = val;
this.rowExpansions.clear();
this._rowCount = this._rows.length;
Copy link
Contributor

@amcdnl amcdnl Jan 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work right since the row count varies. There is a function to get this information.

Copy link
Contributor Author

@ivankolev ivankolev Jan 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aah, I see that /#server-paging is indeed broken with my change. Wonder if it's worth it to maybe add more e2e tests that could potentially catch such errors.

this.recalcLayout();
}

Expand Down