Skip to content

Batch reading content files to prevent too many open files error #12079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thecrypticace merged 5 commits into from
Sep 25, 2023
Merged

Batch reading content files to prevent too many open files error #12079

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f88075a
Refactor
thecrypticace Sep 25, 2023
25de606
Refactor
thecrypticace Sep 25, 2023
ae2f9ea
Batch content file reads in Node into groups of 500
thecrypticace Sep 25, 2023
c847229
Fix sequential/parallel flip
thecrypticace Sep 25, 2023
c3ab1fc
Update changelog
thecrypticace Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Batch content file reads in Node into groups of 500 
We shouldn’t need to do this for our Rust code because it utilizes Rayon’s default thread pool for parallelism. This threadpool has roughly the number of cores as the number of available threads except when overridden. This generally is much, much lower than 500 and can be explicitly overridden via an env var to work around potential issues with open file descriptors if anyone ever runs into that.
  • Loading branch information
@thecrypticace
thecrypticace committed Sep 25, 2023
commit ae2f9ea3e2761c4224aa5627d2a01343fb0528fd
18 changes: 12 additions & 6 deletions src/lib/expandTailwindAtRules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,12 +169,18 @@ export default function expandTailwindAtRules(context) {
}

// Otherwise, read any files in node and parse with regexes
await Promise.all(
regexParserContent.map(async ([{ file, content }, { transformer, extractor }]) => {
content = file ? await fs.promises.readFile(file, 'utf8') : content
getClassCandidates(transformer(content), extractor, candidates, seen)
})
)
const BATCH_SIZE = 500

for (let i = 0; i < regexParserContent.length; i += BATCH_SIZE) {
let batch = regexParserContent.slice(i, i + BATCH_SIZE)

await Promise.all(
batch.map(async ([{ file, content }, { transformer, extractor }]) => {
content = file ? await fs.promises.readFile(file, 'utf8') : content
getClassCandidates(transformer(content), extractor, candidates, seen)
})
)
}

env.DEBUG && console.timeEnd('Reading changed files')

Expand Down