Skip to content

Batch reading content files to prevent too many open files error #12079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thecrypticace merged 5 commits into from
Sep 25, 2023
Merged

Batch reading content files to prevent too many open files error #12079

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f88075a
Refactor
thecrypticace Sep 25, 2023
25de606
Refactor
thecrypticace Sep 25, 2023
ae2f9ea
Batch content file reads in Node into groups of 500
thecrypticace Sep 25, 2023
c847229
Fix sequential/parallel flip
thecrypticace Sep 25, 2023
c3ab1fc
Update changelog
thecrypticace Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Refactor
  • Loading branch information
@thecrypticace
thecrypticace committed Sep 25, 2023
commit f88075af6879a589844a9516705f0633bce42e4f
33 changes: 15 additions & 18 deletions src/lib/expandTailwindAtRules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,11 @@ export default function expandTailwindAtRules(context) {

env.DEBUG && console.time('Reading changed files')

/** @type {[item: {file?: string, content?: string}, meta: {transformer: any, extractor: any}][]} */
let regexParserContent = []

if (flagEnabled(context.tailwindConfig, 'oxideParser')) {
let rustParserContent = []
let regexParserContent = []

for (let item of context.changedContent) {
let transformer = getTransformer(context.tailwindConfig, item.extension)
Expand All @@ -158,26 +160,21 @@ export default function expandTailwindAtRules(context) {
candidates.add(candidate)
}
}

if (regexParserContent.length > 0) {
await Promise.all(
regexParserContent.map(async ([{ file, content }, { transformer, extractor }]) => {
content = file ? await fs.promises.readFile(file, 'utf8') : content
getClassCandidates(transformer(content), extractor, candidates, seen)
})
)
}
} else {
await Promise.all(
context.changedContent.map(async ({ file, content, extension }) => {
let transformer = getTransformer(context.tailwindConfig, extension)
let extractor = getExtractor(context, extension)
content = file ? await fs.promises.readFile(file, 'utf8') : content
getClassCandidates(transformer(content), extractor, candidates, seen)
})
)
for (let item of context.changedContent) {
let transformer = getTransformer(context.tailwindConfig, item.extension)
let extractor = getExtractor(context, item.extension)
regexParserContent.push([item, { transformer, extractor }])
}
}

await Promise.all(
regexParserContent.map(async ([{ file, content }, { transformer, extractor }]) => {
content = file ? await fs.promises.readFile(file, 'utf8') : content
getClassCandidates(transformer(content), extractor, candidates, seen)
})
)

env.DEBUG && console.timeEnd('Reading changed files')

// ---
Expand Down