fix: use userAlias in tmp table#33778
Conversation
Summary of ChangesHello @facetosea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a parsing issue where temporary table column resolution was not correctly utilizing user-defined aliases. The fix involves updating the parser to prioritize Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an issue where user-defined aliases in subqueries were not being resolved properly. The change in parTranslater.c to use userAlias is appropriate. The new tests added in cols_function.py are well-designed and validate the fix. I have one suggestion to improve the new test code for better readability and maintainability.
Description
Please briefly describe the code changes in this pull request.
fix: https://project.feishu.cn/taosdata_td/defect/detail/6482045823
Checklist
Please check the items in the checklist if applicable.