Skip to content

fix: use userAlias in tmp table#33778

Merged
guanshengliang merged 2 commits into3.3.6from
fix/selectValueAliasName3.3.6
Dec 5, 2025
Merged

fix: use userAlias in tmp table#33778
guanshengliang merged 2 commits into3.3.6from
fix/selectValueAliasName3.3.6

Conversation

@facetosea
Copy link
Contributor

@facetosea facetosea commented Dec 2, 2025

Description

Please briefly describe the code changes in this pull request.

fix: https://project.feishu.cn/taosdata_td/defect/detail/6482045823

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @facetosea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a parsing issue where temporary table column resolution was not correctly utilizing user-defined aliases. The fix involves updating the parser to prioritize userAlias for column identification, preventing potential ambiguity. Complementary system tests have been introduced to verify the correct behavior of the cols() function in subqueries, particularly concerning aliased columns and expected error conditions.

Highlights

  • Parser Logic Fix: Corrected the column resolution logic in the SQL parser to use userAlias instead of aliasName when identifying columns within temporary tables. This ensures that user-defined aliases are properly recognized, preventing potential ambiguity.
  • New System Tests: Added new system tests for the cols() function within subqueries, specifically validating correct alias handling and expected error scenarios when accessing aliased columns.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes an issue where user-defined aliases in subqueries were not being resolved properly. The change in parTranslater.c to use userAlias is appropriate. The new tests added in cols_function.py are well-designed and validate the fix. I have one suggestion to improve the new test code for better readability and maintainability.

@guanshengliang guanshengliang merged commit 160e2ac into 3.3.6 Dec 5, 2025
10 of 12 checks passed
@facetosea facetosea deleted the fix/selectValueAliasName3.3.6 branch January 23, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants