Skip to content

fix: use userAlias in tmp table #33778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guanshengliang merged 2 commits into from
Dec 5, 2025
Merged

fix: use userAlias in tmp table #33778

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdf1daa
fix: use userAlias in tmp table
facetosea Dec 1, 2025
f9b88f6
fix: cols function aliasName
facetosea Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: use userAlias in tmp table
  • Loading branch information
@facetosea
facetosea committed Dec 2, 2025
commit bdf1daa286eaf7f2a8b3402672205993a76d08d4
2 changes: 1 addition & 1 deletion source/libs/parser/src/parTranslater.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1636,7 +1636,7 @@ static int32_t findAndSetTempTableColumn(STranslateContext* pCxt, SColumnNode**
SExprNode* pFoundExpr = NULL;
FOREACH(pNode, pProjectList) {
SExprNode* pExpr = (SExprNode*)pNode;
if (0 == strcmp(pCol->colName, pExpr->aliasName)) {
if (0 == strcmp(pCol->colName, pExpr->userAlias)) {
if (*pFound) {
return generateSyntaxErrMsg(&pCxt->msgBuf, TSDB_CODE_PAR_AMBIGUOUS_COLUMN, pCol->colName);
}
Expand Down
13 changes: 13 additions & 0 deletions tests/system-test/2-query/cols_function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,6 +920,19 @@ def subquery_test(self):
tdSql.query(f'select count(1), cols(last(c0),c0) from (select * from test.d0)')
tdSql.query(f'select count(1), cols(last(c0),c0) from (select *, tbname from test.meters) group by tbname')

tdSql.query(f'select last(mts) from (select max(c0) as mc0, cols(max(c0), ts) as mts from test.meters group by tbname)')
tdSql.checkRows(1)
tdSql.checkCols(1)
tdSql.checkData(0, 0, 1734574929004)
tdSql.query(f'select max(mc0) as max_c0, cols(max(mc0), mts) max_ts from (select max(c0) as mc0, cols(max(c0), ts) as mts from test.meters group by tbname)')
tdSql.checkRows(1)
tdSql.checkCols(2)
tdSql.checkData(0, 0, 4)
tdSql.checkData(0, 1, 1734574929004)

tdSql.error(f'select last(ts) from (select max(c0) as mc0, cols(max(c0), ts) as mts from test.meters group by tbname)')
tdSql.error(f'select max(mc0) as max_c0, cols(max(mc0), ts) max_ts from (select max(c0) as mc0, cols(max(c0), ts) as mts from test.meters group by tbname)')

tdLog.info("subquery_test: orderby_test from meters")
self.orderby_test("test.meters", "c0", False)
tdLog.info("subquery_test: orderby_test from (select *, tbname from meters)")
Expand Down
Loading