feat/bom-migration #449
feat/bom-migration #449
Conversation
Qodana Community for JVM262 new problems were found
☁️ View the detailed Qodana report Contact Qodana teamContact us at [email protected]
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| </plugin> | ||
| <plugin> | ||
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <version>${maven-surefire-plugin.version}</version> | ||
| </plugin> | ||
| <plugin> | ||
| <artifactId>maven-failsafe-plugin</artifactId> | ||
| <version>${maven-failsafe-plugin.version}</version> | ||
| </plugin> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> |
There was a problem hiding this comment.
The root POM now lists compiler, surefire, failsafe, jacoco, flatten and source/javadoc plugins without versions or configuration. Because spring-boot-starter-parent was removed, there is no longer a parent supplying pluginManagement, and importing the BOM via <dependencyManagement> does not apply to plugins. Maven will therefore fall back to its built‑in defaults (e.g. maven-compiler-plugin 3.1 and maven-surefire-plugin 2.12.4), which are too old for Java 21 and JUnit 5. Running mvn verify will either fail to compile or silently skip Jupiter tests. The plugin versions that were previously defined via properties need to be restored or managed elsewhere.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Summary
- Restored explicit plugin versions and execution configurations for publishing, compiler, test, and coverage plugins so Maven continues using Java 21-compatible tooling after removing the Spring Boot parent. pom.xmlL101-L238
- Reapplied surefire and failsafe versions in the active build plugins to ensure module builds pick up the managed releases. pom.xmlL241-L258
Testing
- ❌
mvn -T1 -q verify(fails: xyz.tcheeric:nostr-java-bom:1.1.0 is unavailable from Maven Central)
- Configure Qodana to run only on develop, main, and master branches - Configure code formatting to run only on PRs to main or master branches 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
CI now triggers on PRs and pushes to develop, main, and master branches. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
fix: source plugin versions from properties
title: feat: migrate to nostr-java-bom for centralized version management
Summary
Related issue: #____
Migrate nostr-java to use
nostr-java-bomfor centralized dependency version management across the Nostr Java ecosystem. This eliminates duplicate version properties and ensures consistent dependency versions.What changed?
0.4.0→0.5.01.0.0→1.1.0(now includes Spring Boot dependencies)nostr-java-bom.versionproperty (F:pom.xml†L77)nostr-java-bom:1.1.0independencyManagement(F:pom.xml†L87-L93)nostr-java-crypto: removed bcprov-jdk18on version (F:nostr-java-crypto/pom.xml†L37)nostr-java-util: removed commons-lang3 version (F:nostr-java-util/pom.xml†L28)nostr-java-client: removed Spring Boot versions, added compile scope for awaitility (F:nostr-java-client/pom.xml†L56)nostr-java-api: removed Spring Boot versionsBOM Architecture Changes
Benefits
BREAKING
None. Internal build configuration change only; no API or runtime behavior changes.
Protocol Compliance
Testing
mvn clean install -DskipTests -U- BUILD SUCCESSChecklist
type: description