Skip to content

Conversation

@tcheeric
Copy link
Owner

Summary

This pull request incorporates updates to the Maven release and repository configuration to enhance consistency and alignment with Sonatype Central standards. Additionally, it introduces refactorings to the API for improved maintainability and usability.

What changed?

  • Updated Maven command in CI to reference a custom settings file for better build consistency.
  • Adjusted release scripts to support Sonatype Central publishing without overriding default settings.
  • Introduced environment variable-based server credentials for secure publication.
  • Refactored JsonDeserialize builder references to ensure proper deserialization.
  • Simplified event-building methods by removing redundant sender parameter, breaking backward compatibility to favor a streamlined API.
  • Updated default sender handling in the event builder for consistent behavior across creation methods.
  • Deprecated and removed unused APIs to further clean up the codebase and enforce structured modernization.

BREAKING

⚠️ BREAKING:

  • Configuration for publishing now requires CENTRAL_USERNAME and CENTRAL_PASSWORD environment variables for deployments.
  • Event-building methods no longer accept a sender parameter. Users must migrate to the instance-configured sender pattern.
  • Deprecated APIs have been removed, necessitating updates for clients relying on those.

Review focus

Focus on:

  • Potential build edge cases introduced during Maven command refactor.
  • API simplifications ensuring no additional burdens for client adoption.
  • Alignment of configuration changes with best practices for secure publishing.

Checklist

  • Scope ≤ 300 lines (or split/stack)
  • Title is verb + object (e.g., “Refactor auth middleware to async”)
  • Description links the issue and answers “why now?”
  • BREAKING flagged if needed
  • Tests/docs updated (if relevant

erict875 added 2 commits October 14, 2025 03:02
- Corrected the reference to the builder class for JsonDeserialize
  annotation in CalendarRsvpContent to ensure proper deserialization.
- Bump the project version from 1.0.0 to 1.0.1 across all modules.
- Add explicit names for each artifact in the pom.xml for clarity.
@tcheeric tcheeric merged commit de6ca6a into main Oct 14, 2025
5 checks passed
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment on lines +47 to +50
<scm>
<connection>scm:git:git://github.com/tcheeric/nostr-java.git</connection>
<developerConnection>scm:git:ssh://github.com:tcheeric/nostr-java.git</developerConnection>
<url>https://github.com/tcheeric/nostr-java/tree/main</url>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Fix malformed Maven SCM developerConnection

The newly added <developerConnection> uses scm:git:ssh://github.com:tcheeric/nostr-java.git, which is not a valid SSH URL because the portion after github.com: is treated as a port rather than the repository path. Maven release plugins and Sonatype Central metadata validation rely on this field and will fail to clone or tag the repo with the current value. Use the canonical form (scm:git:ssh://[email protected]/tcheeric/nostr-java.git or scm:git:[email protected]:tcheeric/nostr-java.git) so publishing workflows can resolve the repository correctly.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants