Skip to content

Update Maven settings and consolidate API improvements #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tcheeric merged 2 commits into from
Oct 14, 2025
Merged

Update Maven settings and consolidate API improvements #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
deda83e
refactor(api): update JsonDeserialize builder reference
Oct 14, 2025
71ec714
chore(pom): update project version to 1.0.1 and add artifact names
Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion nostr-java-api/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,13 @@
<parent>
<groupId>xyz.tcheeric</groupId>
<artifactId>nostr-java</artifactId>
<version>1.0.0</version>
<version>1.0.1</version>
<relativePath>../pom.xml</relativePath>
</parent>

<artifactId>nostr-java-api</artifactId>
<packaging>jar</packaging>
<name>nostr-java-api</name>

<distributionManagement>
<repository>
Expand Down
3 changes: 2 additions & 1 deletion nostr-java-base/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,13 @@
<parent>
<groupId>xyz.tcheeric</groupId>
<artifactId>nostr-java</artifactId>
<version>1.0.0</version>
<version>1.0.1</version>
<relativePath>../pom.xml</relativePath>
</parent>

<artifactId>nostr-java-base</artifactId>
<packaging>jar</packaging>
<name>nostr-java-base</name>

<distributionManagement>
<repository>
Expand Down
3 changes: 2 additions & 1 deletion nostr-java-client/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,13 @@
<parent>
<groupId>xyz.tcheeric</groupId>
<artifactId>nostr-java</artifactId>
<version>1.0.0</version>
<version>1.0.1</version>
<relativePath>../pom.xml</relativePath>
</parent>

<artifactId>nostr-java-client</artifactId>
<packaging>jar</packaging>
<name>nostr-java-client</name>

<distributionManagement>
<repository>
Expand Down
3 changes: 2 additions & 1 deletion nostr-java-crypto/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,13 @@
<parent>
<groupId>xyz.tcheeric</groupId>
<artifactId>nostr-java</artifactId>
<version>1.0.0</version>
<version>1.0.1</version>
<relativePath>../pom.xml</relativePath>
</parent>

<artifactId>nostr-java-crypto</artifactId>
<packaging>jar</packaging>
<name>nostr-java-crypto</name>

<distributionManagement>
<repository>
Expand Down
2 changes: 1 addition & 1 deletion nostr-java-encryption/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>xyz.tcheeric</groupId>
<artifactId>nostr-java</artifactId>
<version>1.0.0</version>
<version>1.0.1</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
3 changes: 2 additions & 1 deletion nostr-java-event/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,13 @@
<parent>
<groupId>xyz.tcheeric</groupId>
<artifactId>nostr-java</artifactId>
<version>1.0.0</version>
<version>1.0.1</version>
<relativePath>../pom.xml</relativePath>
</parent>

<artifactId>nostr-java-event</artifactId>
<packaging>jar</packaging>
<name>nostr-java-event</name>

<distributionManagement>
<repository>
Expand Down
3 changes: 1 addition & 2 deletions nostr-java-event/src/main/java/nostr/event/entities/CalendarRsvpContent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.NonNull;
import nostr.event.entities.CalendarRsvpContent.CalendarRsvpContentBuilder;
import nostr.event.tag.AddressTag;
import nostr.event.tag.EventTag;
import nostr.event.tag.GenericTag;
Expand All @@ -15,7 +14,7 @@
import java.util.Optional;

@Builder
@JsonDeserialize(builder = CalendarRsvpContentBuilder.class)
@JsonDeserialize(builder = CalendarRsvpContent.CalendarRsvpContentBuilder.class)
@EqualsAndHashCode(callSuper = false)
public class CalendarRsvpContent extends NIP42Content {

Expand Down
3 changes: 2 additions & 1 deletion nostr-java-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,13 @@
<parent>
<groupId>xyz.tcheeric</groupId>
<artifactId>nostr-java</artifactId>
<version>1.0.0</version>
<version>1.0.1</version>
<relativePath>../pom.xml</relativePath>
</parent>

<artifactId>nostr-java-examples</artifactId>
<packaging>jar</packaging>
<name>nostr-java-examples</name>

<distributionManagement>
<repository>
Expand Down
3 changes: 2 additions & 1 deletion nostr-java-id/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,13 @@
<parent>
<groupId>xyz.tcheeric</groupId>
<artifactId>nostr-java</artifactId>
<version>1.0.0</version>
<version>1.0.1</version>
<relativePath>../pom.xml</relativePath>
</parent>

<artifactId>nostr-java-id</artifactId>
<packaging>jar</packaging>
<name>nostr-java-id</name>

<distributionManagement>
<repository>
Expand Down
3 changes: 2 additions & 1 deletion nostr-java-util/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,13 @@
<parent>
<groupId>xyz.tcheeric</groupId>
<artifactId>nostr-java</artifactId>
<version>1.0.0</version>
<version>1.0.1</version>
<relativePath>../pom.xml</relativePath>
</parent>

<artifactId>nostr-java-util</artifactId>
<packaging>jar</packaging>
<name>nostr-java-util</name>

<distributionManagement>
<repository>
Expand Down
81 changes: 80 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

<groupId>xyz.tcheeric</groupId>
<artifactId>nostr-java</artifactId>
<version>1.0.0</version>
<version>1.0.1</version>
<packaging>pom</packaging>

<name>${project.artifactId}</name>
Expand Down Expand Up @@ -44,6 +44,12 @@
</developer>
</developers>

<scm>
<connection>scm:git:git://github.com/tcheeric/nostr-java.git</connection>
<developerConnection>scm:git:ssh://github.com:tcheeric/nostr-java.git</developerConnection>
<url>https://github.com/tcheeric/nostr-java/tree/main</url>
Comment on lines +47 to +50
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Fix malformed Maven SCM developerConnection

The newly added <developerConnection> uses scm:git:ssh://github.com:tcheeric/nostr-java.git, which is not a valid SSH URL because the portion after github.com: is treated as a port rather than the repository path. Maven release plugins and Sonatype Central metadata validation rely on this field and will fail to clone or tag the repo with the current value. Use the canonical form (scm:git:ssh://[email protected]/tcheeric/nostr-java.git or scm:git:[email protected]:tcheeric/nostr-java.git) so publishing workflows can resolve the repository correctly.

Useful? React with 👍 / 👎.

</scm>

<distributionManagement>
<repository>
<id>reposilite-releases</id>
Expand Down Expand Up @@ -184,12 +190,25 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>${maven.javadoc.plugin.version}</version>
<configuration>
<doclint>none</doclint>
<quiet>true</quiet>
<source>21</source>
<detectJavaApiLink>false</detectJavaApiLink>
<additionalOptions>
<additionalOption>-Xdoclint:none</additionalOption>
</additionalOptions>
</configuration>
<executions>
<execution>
<id>attach-javadocs</id>
<phase>package</phase>
<goals>
<goal>jar</goal>
</goals>
<configuration>
<sourcepath>${project.build.sourceDirectory};${project.build.directory}/generated-sources/annotations</sourcepath>
</configuration>
</execution>
</executions>
</plugin>
Expand Down Expand Up @@ -245,6 +264,13 @@
<configuration>
<source>${maven.compiler.source}</source>
<target>${maven.compiler.target}</target>
<annotationProcessorPaths>
<path>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>1.18.36</version>
</path>
</annotationProcessorPaths>
</configuration>
</plugin>
<plugin>
Expand Down Expand Up @@ -401,6 +427,59 @@
<id>release-central</id>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
</plugin>
<plugin>
<groupId>org.projectlombok</groupId>
<artifactId>lombok-maven-plugin</artifactId>
<version>1.18.20.0</version>
<executions>
<execution>
<phase>generate-sources</phase>
<goals>
<goal>delombok</goal>
</goals>
<configuration>
<addOutputDirectory>false</addOutputDirectory>
<sourceDirectory>src/main/java</sourceDirectory>
</configuration>
</execution>
</executions>
<dependencies>
<dependency>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>1.18.36</version>
</dependency>
</dependencies>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<configuration>
<doclint>none</doclint>
<quiet>true</quiet>
<source>21</source>
<detectJavaApiLink>false</detectJavaApiLink>
<additionalOptions>
<additionalOption>-Xdoclint:none</additionalOption>
</additionalOptions>
</configuration>
<executions>
<execution>
<id>attach-javadocs</id>
<phase>package</phase>
<goals>
<goal>jar</goal>
</goals>
<configuration>
<sourcepath>${project.build.directory}/generated-sources/delombok</sourcepath>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId>
Expand Down
Loading