Skip to content

Conversation

@mbainter
Copy link
Contributor

@mbainter mbainter commented Jan 6, 2022

Description

This PR adds a rule for accessing the tentacle endpoints on target
nodes for the Octopus deploy system.

Motivation and Context

For organizations using Octopus this rule is needed for any target endpoints Octopus deploys to. Having the rule simplifies use of this module. I did not create a "module" for it because technically this works alongside other modules and I'm not sure it makes sense as a standalone implementation. Happy to add that to the PR if others disagree.

Breaking Changes

This should be a simple net add with no breaking changes.

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
    It isn't making code changes, simply a shortcut rule addition. This works in my fork when applied in a sample implementation, but as a new shortcut rule it isn't included in the examples.

This adds a rule for accessing the tentacle endpoints on target
nodes for the [Octopus](https://octopus.com/docs/security/exposing-octopus) deploy system.
@mbainter mbainter force-pushed the feature/octopus-tentacle-rule branch from 6ee090a to f05eba7 Compare January 6, 2022 22:09
@antonbabenko antonbabenko changed the title add rule for octopus tentacles feat: Add rule for octopus tentacles Jan 10, 2022
@antonbabenko antonbabenko merged commit 55b75b3 into terraform-aws-modules:master Jan 10, 2022
antonbabenko pushed a commit that referenced this pull request Jan 10, 2022
## [4.8.0](v4.7.0...v4.8.0) (2022-01-10)

### Features

* Add rule for octopus tentacles ([#236](#236)) ([55b75b3](55b75b3))
@antonbabenko
Copy link
Member

This PR is included in version 4.8.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants