Skip to content

store: Fixed binary header bug that was causing all postings to be kept in memory instead of 1/32 as we meant. #2390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bwplotka merged 4 commits into from
Apr 8, 2020
Merged

store: Fixed binary header bug that was causing all postings to be kept in memory instead of 1/32 as we meant. #2390

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a730f0c
store: Fixed binary header bug that was causing all postings to be ke…
bwplotka Apr 7, 2020
c78ce9d
Added CHANGELOG item.
bwplotka Apr 7, 2020
27a4a23
Fixed build errs.
bwplotka Apr 7, 2020
03b42c9
Addressed Lucas comment.
bwplotka Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Addressed Lucas comment. 
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
  • Loading branch information
@bwplotka
bwplotka committed Apr 7, 2020
commit 03b42c91c35f5b6077d66e516a41c61c06ae556e
4 changes: 2 additions & 2 deletions pkg/block/indexheader/binary_reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,12 +426,12 @@ type BinaryReader struct {
c io.Closer

// Map of LabelName to a list of some LabelValues's position in the offset table.
// The first and last values for each name are always present, we keep only `symbolsFactor` part of for rest.
// The first and last values for each name are always present, we keep only 1/postingOffsetsInMemSampling of the rest.
postings map[string]*postingValueOffsets
// For the v1 format, labelname -> labelvalue -> offset.
postingsV1 map[string]map[string]index.Range

// Symbols struct that keeps only `symbolsFactor` part in the memory, looks up via mmap rest.
// Symbols struct that keeps only 1/postingOffsetsInMemSampling in the memory, then looks up the rest via mmap.
symbols *index.Symbols
nameSymbols map[uint32]string // Cache of the label name symbol lookups,
// as there are not many and they are half of all lookups.
Expand Down