Skip to content

store: Fixed binary header bug that was causing all postings to be kept in memory instead of 1/32 as we meant. #2390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bwplotka merged 4 commits into from
Apr 8, 2020
Merged

store: Fixed binary header bug that was causing all postings to be kept in memory instead of 1/32 as we meant. #2390

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a730f0c
store: Fixed binary header bug that was causing all postings to be ke…
bwplotka Apr 7, 2020
c78ce9d
Added CHANGELOG item.
bwplotka Apr 7, 2020
27a4a23
Fixed build errs.
bwplotka Apr 7, 2020
03b42c9
Addressed Lucas comment.
bwplotka Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed build errs. 
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
  • Loading branch information
@bwplotka
bwplotka committed Apr 7, 2020
commit 27a4a235fa62ead7743bb443c730b511e82255ad
1 change: 1 addition & 0 deletions pkg/store/bucket_e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ func prepareStoreWithTestBlocks(t testing.TB, dir string, bkt objstore.Bucket, m
true,
true,
true,
DefaultPostingOffsetInMemorySampling,
)
testutil.Ok(t, err)
s.store = store
Expand Down
2 changes: 2 additions & 0 deletions pkg/store/bucket_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,7 @@ func TestBucketStore_Info(t *testing.T) {
true,
true,
true,
DefaultPostingOffsetInMemorySampling,
)
testutil.Ok(t, err)

Expand Down Expand Up @@ -732,6 +733,7 @@ func testSharding(t *testing.T, reuseDisk string, bkt objstore.Bucket, all ...ul
true,
true,
true,
DefaultPostingOffsetInMemorySampling,
)
testutil.Ok(t, err)

Expand Down