objstore/azure: Disable Azure blob exception logging#3331
Merged
kakkoyun merged 1 commit intothanos-io:masterfrom Oct 19, 2020
pharaujo:issue-2565
Merged
objstore/azure: Disable Azure blob exception logging#3331kakkoyun merged 1 commit intothanos-io:masterfrom pharaujo:issue-2565
kakkoyun merged 1 commit intothanos-io:masterfrom
pharaujo:issue-2565
Conversation
bwplotka
approved these changes
Oct 17, 2020
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
LGTM, just would be nice to comment on surprises. Value -1 turning off something is super weird (:
Thanks!
Ever since the introduction of the deletion marker, Thanos compact has been filling the logs with Azure blob storage exceptions. As discussed in #2565, the error logging should be handled by Thanos itself, so this patch turns off standard logging from the Azure library. However, [due to the way logging is set up in the library][1], it will always log errors to syslog, regardless of how `ShouldLog` is configured. As such, and until that can be a configurable behavior, care should be taken to handle that from the syslog side as well. [1]: https://github.com/Azure/azure-storage-blob-go/blob/48358e1de5110852097ebbc11c53581d64d47300/azblob/zc_policy_request_log.go#L100-L102 Signed-off-by: Pedro Araujo <phcrva@gmail.com>
Contributor
Author
Yeah, I agree. The whole logging method is super weird, it forces logging even if you explicitly request for it to not log. I plan on at least opening an issue for that on their end. |
Contributor
Author
|
@bwplotka I didn't change anything since the previous commit that would cause the failed test, only added a comment as discussed. How should I proceed? |
2 tasks
kakkoyun
pushed a commit
that referenced
this pull request
Oct 20, 2020
As a follow-up to #3331, this disables Azure exception logging to syslog. Signed-off-by: Pedro Araujo <phcrva@gmail.com>
pharaujo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ever since the introduction of the deletion marker, Thanos compact has been filling the logs with Azure blob storage exceptions. As discussed in #2565, the error logging should be handled by Thanos itself, so this patch turns off standard logging from the Azure library.
However, due to the way logging is set up in the library, it will always log errors to syslog, regardless of how
ShouldLogis configured. As such, and until that can be a configurable behavior, care should be taken to handle that from the syslog side as well.Changes
Disabled exception logging from the Azure Blob storage module
Verification
Compiled locally and ran
thanos compactagainst an Azure blob storage container.