objstore/azure: Disable Azure syslog exception logging#3341
Merged
kakkoyun merged 1 commit intothanos-io:masterfrom Oct 20, 2020
pharaujo:issue-2565-2
Merged
objstore/azure: Disable Azure syslog exception logging#3341kakkoyun merged 1 commit intothanos-io:masterfrom pharaujo:issue-2565-2
kakkoyun merged 1 commit intothanos-io:masterfrom
pharaujo:issue-2565-2
Conversation
Contributor
Author
|
I ran e2e tests locally and they pass. Seems like the failures are test flakiness? Do you want me to any additional validation on my side? |
kakkoyun
reviewed
Oct 20, 2020
Member
kakkoyun
left a comment
kakkoyun
left a comment
There was a problem hiding this comment.
Looking good so far. Thanks a lot for the contribution.
I have added a couple of comments.
As a follow-up to #3331, this disables Azure exception logging to syslog. Signed-off-by: Pedro Araujo <phcrva@gmail.com>
kakkoyun
approved these changes
Oct 20, 2020
Member
kakkoyun
left a comment
kakkoyun
left a comment
There was a problem hiding this comment.
🥇 Thanks for your contribution and sorry for the iterations.
kakkoyun
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow-up to #3331, this disables Azure exception logging to syslog.
Fixes #2565
Changes
Disabled Azure pipeline
ForceLog.Verification
Ran a build of my branch against an Azure blob storage container and confirmed no further exceptions were being sent to syslog.