UI: Add toggle to enable/disable metric autocomplete#3381
Merged
bwplotka merged 4 commits intothanos-io:masterfrom Oct 30, 2020
Merged
UI: Add toggle to enable/disable metric autocomplete#3381bwplotka merged 4 commits intothanos-io:masterfrom
bwplotka merged 4 commits intothanos-io:masterfrom
Conversation
This change adds a toggle to enable or disable the metric autocomplete functionality. By default it is enabled. Signed-off-by: Jarod Watkins <jarod@42lines.net>
Signed-off-by: Jarod Watkins <jarod@42lines.net>
Signed-off-by: Jarod Watkins <jarod@42lines.net>
GiedriusS
reviewed
Oct 29, 2020
Member
GiedriusS
left a comment
GiedriusS
left a comment
There was a problem hiding this comment.
Could you please do make assets and commit the result? We really need to fix the CI part here :(
Signed-off-by: Jarod Watkins <jarod@42lines.net>
Contributor
Author
Done. No worries. |
ipstatic
added a commit
to ipstatic/prometheus
that referenced
this pull request
Oct 30, 2020
This change adds a toggle to enable or disable the metric autocomplete functionality. By default it is enabled. This is a port of a change I did in [Thanos][1]. [1]: thanos-io/thanos#3381 Signed-off-by: Jarod Watkins <jarod@42lines.net>
Contributor
Author
|
I also implemented this change "upstream" in Prometheus |
bwplotka
approved these changes
Oct 30, 2020
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
LGTM! Can we have quick screenshot how this checkbox looks like? (:
Thanks!
Contributor
Author
|
Contributor
Author
|
Oh I forgot to add a changelog entry! How should I correct? |
Member
|
That's fine, we can add later during release (:
Kind Regards,
Bartek Płotka (@bwplotka)
…On Fri, 30 Oct 2020 at 20:38, Jarod Watkins ***@***.***> wrote:
Oh I forgot to add a changelog entry! How should I correct?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#3381 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVA3O73FR3KPRD4XIWME2TSNMI4DANCNFSM4TEDKPEQ>
.
|
juliusv
pushed a commit
to prometheus/prometheus
that referenced
this pull request
Nov 2, 2020
* UI: Add toggle to enable/disable metric autocomplete This change adds a toggle to enable or disable the metric autocomplete functionality. By default it is enabled. This is a port of a change I did in [Thanos][1]. [1]: thanos-io/thanos#3381 Signed-off-by: Jarod Watkins <jarod@42lines.net> * Adding full variable name Signed-off-by: Jarod Watkins <jarod@42lines.net>
Contributor
Author
|
FYI I have created another PR to bring in changes suggested by Prometheus developers: #3391 |
Oghenebrume50
pushed a commit
to Oghenebrume50/thanos
that referenced
this pull request
Dec 7, 2020
* UI: Add toggle to enable/disable metric autocomplete This change adds a toggle to enable or disable the metric autocomplete functionality. By default it is enabled. Signed-off-by: Jarod Watkins <jarod@42lines.net> * Fixing tests Signed-off-by: Jarod Watkins <jarod@42lines.net> * Fixing lint suggestions Signed-off-by: Jarod Watkins <jarod@42lines.net> * Run make assets Signed-off-by: Jarod Watkins <jarod@42lines.net> Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a toggle to enable or disable the metric autocomplete
functionality. By default it is enabled.
Signed-off-by: Jarod Watkins jarod@42lines.net
Changes
Added toggle to enable/disable metric autocomplete functionality in the new UI.
Verification
Tested locally against production data.