Skip to content

Querier UI: Updating enable/disable metric automcomplete with upstream#3391

Merged
GiedriusS merged 3 commits intothanos-io:masterfrom
ipstatic:sync-enable-metric-autocomplete-prometheus
Nov 5, 2020
Merged

Querier UI: Updating enable/disable metric automcomplete with upstream#3391
GiedriusS merged 3 commits intothanos-io:masterfrom
ipstatic:sync-enable-metric-autocomplete-prometheus

Conversation

@ipstatic
Copy link
Contributor

@ipstatic ipstatic commented Nov 2, 2020

Bringing in changes suggested by Prometheus developers to keep in sync.
Also updated CHANGELOG.

Signed-off-by: Jarod Watkins jarod@42lines.net

Bringing in changes suggested by Prometheus developers to keep in sync.
Also updated CHANGELOG.

Signed-off-by: Jarod Watkins <jarod@42lines.net>
@ipstatic
Copy link
Contributor Author

ipstatic commented Nov 2, 2020

FYI I attempted a make assets but it appears there was no change.

@onprem
Copy link
Member

onprem commented Nov 3, 2020

FYI I attempted a make assets but it appears there was no change.

Yeah, this happens sometimes, when make thinks that everything is already latest. Try running scripts/build-react-app.sh directly and then make assets.

Signed-off-by: Jarod Watkins <jarod@42lines.net>
@ipstatic
Copy link
Contributor Author

ipstatic commented Nov 4, 2020

That did it, thanks!

Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@GiedriusS
Copy link
Member

CircleCI does not want to cooperate today and simply returns 400 when trying to resubmit the payload for this pull request. The tests pass and everything looks good, thank you!

@GiedriusS GiedriusS merged commit 1854422 into thanos-io:master Nov 5, 2020
Oghenebrume50 pushed a commit to Oghenebrume50/thanos that referenced this pull request Dec 7, 2020
thanos-io#3391)

* Querier UI: Updating enable/disable metric automcomplete with upstream

Bringing in changes suggested by Prometheus developers to keep in sync.
Also updated CHANGELOG.

Signed-off-by: Jarod Watkins <jarod@42lines.net>

* Make assets

Signed-off-by: Jarod Watkins <jarod@42lines.net>
Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants