Skip to content

Conversation

@blaaat
Copy link

@blaaat blaaat commented Mar 16, 2018

Found some sites using:
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8;">

changed regex to ignore this trailing semicolon.

@alcaeus
Copy link

alcaeus commented Mar 20, 2018

Can you please add a test to cover the new functionality? Ideally, the test fails without your patch and passes with it. Thanks!

@alcaeus alcaeus self-assigned this Mar 20, 2018
@blaaat
Copy link
Author

blaaat commented Mar 23, 2018

I've added a test (the example above) which fails in the old code base and passes now.

@alcaeus alcaeus merged commit 402f2e5 into thesoftwarefanatics:master Mar 26, 2018
@alcaeus
Copy link

alcaeus commented Mar 26, 2018

Thanks @blaaat!

@alcaeus alcaeus added this to the 1.8.1 milestone Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants