Skip to content

Ignore ; or space after charset in meta tag #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 26, 2018
Merged

Ignore ; or space after charset in meta tag #7

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
346e2ea
Ignore ; or space after charset in meta tag
blaaat Mar 16, 2018
fd38f92
Added test with invalid content-type meta tag
blaaat Mar 23, 2018
c0a436f
prevent double convert of attributes
blaaat Mar 23, 2018
4046e83
Test for double charset conversion fix
blaaat Mar 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Test for double charset conversion fix
  • Loading branch information
@blaaat
blaaat committed Mar 23, 2018
commit 4046e83fdae8109770598fc332b081c1dfba55d4
8 changes: 8 additions & 0 deletions tests/DomTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,14 @@ public function testIncorrectContentType()
$this->assertEquals($a->text, 'click here');
}

public function testCharsetConvertInAttribute()
{
$dom = new Dom;
$dom->loadFromFile(__DIR__ . '/files/ISO-8859-7.html', ['preserveLineBreaks' => true]);
$a = $dom->find('a', 0);
$this->assertEquals('/testη', $a->href);
}

public function testLoadSelfclosingAttr()
{
$dom = new Dom;
Expand Down
8 changes: 8 additions & 0 deletions tests/files/ISO-8859-7.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-7">
</head>
<body>
<a href="/test�">EE�<span>XX</span></a>
</body>
</html>