-
Notifications
You must be signed in to change notification settings - Fork 629
Add providerOverride as an option for fiat payments #5330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5330 +/- ##
==========================================
- Coverage 45.69% 45.69% -0.01%
==========================================
Files 1069 1069
Lines 55588 55590 +2
Branches 4062 4062
==========================================
Hits 25403 25403
- Misses 29496 29498 +2
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more.
|
| * By default, we choose a recommended provider based on the location of the user, KYC status, and currency. | ||
| * If this is set, we will always choose this specific onramp provider, or error if this provider cannot support the user. | ||
| */ | ||
| providerOverride?: FiatProvider; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its weird to have both options. i think if ppl expect to be able to override, then lets just change the behavior of preferred to error if its not available
Problem solved
Allow customers to override the fiat provider routing and specify the provider they want.
Fixes https://linear.app/thirdweb/issue/CNCT-2227/pro-only-keep-stripe-as-a-provider-for-pay
PR-Codex overview
This PR introduces the ability to specify a custom fiat provider through a new
providerOverrideparameter across several components, enhancing flexibility in fiat transactions.Detailed summary
providerOverrideparameter toConnectButtonProps.ts.useSendTransaction.tsto includeproviderOverride.BuyScreen.tsxto passproviderOverridefrombuyWithFiatOptions.getQuote.tswith documentation forproviderOverride.