Skip to content

Add providerOverride as an option for fiat payments #5330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
edwardysun wants to merge 2 commits into from
Closed

Add providerOverride as an option for fiat payments #5330

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
008cae5
Add providerOverride as an option for fiat payments
edwardysun Nov 6, 2024
8318871
changeset
edwardysun Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add providerOverride as an option for fiat payments
  • Loading branch information
@edwardysun
edwardysun committed Nov 6, 2024
commit 008cae597195066550b63392bde8b81456ff2667
9 changes: 9 additions & 0 deletions packages/thirdweb/src/pay/buyWithFiat/getQuote.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,14 @@ export type GetBuyWithFiatQuoteParams = {
* By default, we choose a recommended provider based on the location of the user, KYC status, and currency.
*/
preferredProvider?: FiatProvider;

/**
* Optional parameter to specify an overriding onramp provider.
*
* By default, we choose a recommended provider based on the location of the user, KYC status, and currency.
* If this is set, we will always choose this specific onramp provider, or error if this provider cannot support the user.
*/
providerOverride?: FiatProvider;
Copy link
Member

@joaquim-verges joaquim-verges Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its weird to have both options. i think if ppl expect to be able to override, then lets just change the behavior of preferred to error if its not available

};

/**
Expand Down Expand Up @@ -313,6 +321,7 @@ export async function getBuyWithFiatQuote(
fromAddress: params.fromAddress,
toGasAmountWei: params.toGasAmountWei,
preferredProvider: params.preferredProvider,
providerOverride: params.providerOverride,
}),
});

Expand Down
1 change: 1 addition & 0 deletions packages/thirdweb/src/react/core/hooks/connection/ConnectButtonProps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ export type PayUIOptions = Prettify<
currency?: "USD" | "CAD" | "GBP" | "EUR" | "JPY";
};
preferredProvider?: FiatProvider;
providerOverride?: FiatProvider;
}
| false;

Expand Down
1 change: 1 addition & 0 deletions packages/thirdweb/src/react/core/hooks/transaction/useSendTransaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ export type SendTransactionPayModalConfig =
};
testMode?: boolean;
preferredProvider?: FiatProvider;
providerOverride?: FiatProvider;
};
purchaseData?: object;
/**
Expand Down
1 change: 1 addition & 0 deletions packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1247,6 +1247,7 @@ function FiatScreenContent(props: {
purchaseData: props.payOptions.purchaseData,
fromAddress: payer.account.address,
preferredProvider: buyWithFiatOptions?.preferredProvider,
providerOverride: buyWithFiatOptions?.providerOverride,
}
: undefined,
);
Expand Down