Skip to content

Fix ITestSkippedEventReceiver not firing for [Skip]-attributed tests #5253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 3 commits into from
Mar 26, 2026
Merged

Fix ITestSkippedEventReceiver not firing for [Skip]-attributed tests #5253

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
beedbce
Fix ITestSkippedEventReceiver not firing for [Skip]-attributed tests
thomhurst Mar 26, 2026
dd67ea5
Add exactly-once invocation guard tests for skip event receivers
thomhurst Mar 26, 2026
4bb5329
Use DependsOn with ProceedOnFailure for skip event receiver test
thomhurst Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions TUnit.Engine/Services/TestExecution/TestCoordinator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ private async ValueTask ExecuteTestInternalAsync(AbstractExecutableTest test, Ca

_contextRestorer.RestoreContext(test);

// Register event receivers early so that skip event receivers work
// even when the test is skipped before full initialization.
_eventReceiverOrchestrator.RegisterReceivers(test.Context, cancellationToken);

// Check if test was already marked as skipped during registration
// (e.g., by a derived SkipAttribute evaluated in OnTestRegistered).
// This must be checked before any instance creation or retry/timeout logic.
Expand Down
Loading