Skip to content

fix(assertions): prevent implicit-to-string op from NREing on null (#5692) #5696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 3 commits into from
Apr 24, 2026
Merged

fix(assertions): prevent implicit-to-string op from NREing on null (#5692) #5696

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d80f33c
fix(assertions): prevent implicit-to-string op from NREing on null (#…
thomhurst Apr 24, 2026
0385e9e
test(public-api): update assertion snapshots for StringValue overload
thomhurst Apr 24, 2026
02e9e7d
fix(tests): correct Memory/ReadOnlyMemory assertion type refs (#5696)
thomhurst Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(tests): correct Memory/ReadOnlyMemory assertion type refs (#5696) 
MemoryAssertion<T> and ReadOnlyMemoryAssertion<T> are only defined for
NET5_0_OR_GREATER, so the two tests referencing them failed to compile on
net472. Wrap those two tests in the matching preprocessor guard so net472
builds succeed while keeping full coverage on modern TFMs.
  • Loading branch information
@thomhurst
thomhurst committed Apr 24, 2026
commit 02e9e7d5b1b3a90f32ab14b2725580ab9b74d9bd
2 changes: 2 additions & 0 deletions TUnit.Assertions.Tests/Bugs/Issue5692/ImplicitStringOperatorOverloadTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ public async Task DictionaryOfStringInt_RoutesToMutableDictionaryAssertion()
await Assert.That(assertion).IsTypeOf<MutableDictionaryAssertion<string, int>>();
}

#if NET5_0_OR_GREATER
[Test]
public async Task MemoryOfChar_RoutesToMemoryAssertion()
{
Expand All @@ -200,6 +201,7 @@ public async Task ReadOnlyMemoryOfChar_RoutesToReadOnlyMemoryAssertion()
var assertion = Assert.That(mem);
await Assert.That(assertion).IsTypeOf<ReadOnlyMemoryAssertion<char>>();
}
#endif

// ============ Delegate / Task overloads unchanged ============

Expand Down
Loading