Skip to content

fix(assertions): prevent implicit-to-string op from NREing on null (#5692) #5696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 3 commits into from
Apr 24, 2026
Merged

fix(assertions): prevent implicit-to-string op from NREing on null (#5692) #5696

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d80f33c
fix(assertions): prevent implicit-to-string op from NREing on null (#…
thomhurst Apr 24, 2026
0385e9e
test(public-api): update assertion snapshots for StringValue overload
thomhurst Apr 24, 2026
02e9e7d
fix(tests): correct Memory/ReadOnlyMemory assertion type refs (#5696)
thomhurst Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(public-api): update assertion snapshots for StringValue overload
  • Loading branch information
@thomhurst
thomhurst committed Apr 24, 2026
commit 0385e9e19b42e9da1273f93a768182c2dc07f8b8
7 changes: 6 additions & 1 deletion TUnit.PublicAPI/Tests.Assertions_Library_Has_No_API_Changes.DotNet10_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ namespace
public static . That(<.> action, [.("action")] string? expression = null) { }
public static . That(. task, [.("task")] string? expression = null) { }
[.(2)]
public static .<string> That(string? value, [.("value")] string? expression = null) { }
public static .<string> That(.StringValue value, [.("value")] string? expression = null) { }
[.(3)]
public static .<TItem> That<TItem>(.<TItem>? value, [.("value")] string? expression = null) { }
[.(1)]
Expand Down Expand Up @@ -271,6 +271,11 @@ namespace
public static .StringMatcher AsRegex(string pattern) { }
public static .StringMatcher AsWildcard(string pattern) { }
}
public readonly struct StringValue
{
public string? Value { get; }
public static .StringValue op_Implicit(string? value) { }
}
}
namespace .
{
Expand Down
7 changes: 6 additions & 1 deletion TUnit.PublicAPI/Tests.Assertions_Library_Has_No_API_Changes.DotNet8_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ namespace
public static .<object?> That(.IEnumerable value, [.("value")] string? expression = null) { }
public static . That(<.> action, [.("action")] string? expression = null) { }
public static . That(. task, [.("task")] string? expression = null) { }
public static .<string> That(string? value, [.("value")] string? expression = null) { }
public static .<string> That(.StringValue value, [.("value")] string? expression = null) { }
public static .<TItem> That<TItem>(.<TItem>? value, [.("value")] string? expression = null) { }
public static .<TItem> That<TItem>(.<TItem> value, [.("value")] string? expression = null) { }
public static .<TItem> That<TItem>(.<TItem>? value, [.("value")] string? expression = null) { }
Expand Down Expand Up @@ -254,6 +254,11 @@ namespace
public static .StringMatcher AsRegex(string pattern) { }
public static .StringMatcher AsWildcard(string pattern) { }
}
public readonly struct StringValue
{
public string? Value { get; }
public static .StringValue op_Implicit(string? value) { }
}
}
namespace .
{
Expand Down
7 changes: 6 additions & 1 deletion TUnit.PublicAPI/Tests.Assertions_Library_Has_No_API_Changes.DotNet9_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ namespace
public static . That(<.> action, [.("action")] string? expression = null) { }
public static . That(. task, [.("task")] string? expression = null) { }
[.(2)]
public static .<string> That(string? value, [.("value")] string? expression = null) { }
public static .<string> That(.StringValue value, [.("value")] string? expression = null) { }
[.(3)]
public static .<TItem> That<TItem>(.<TItem>? value, [.("value")] string? expression = null) { }
[.(1)]
Expand Down Expand Up @@ -271,6 +271,11 @@ namespace
public static .StringMatcher AsRegex(string pattern) { }
public static .StringMatcher AsWildcard(string pattern) { }
}
public readonly struct StringValue
{
public string? Value { get; }
public static .StringValue op_Implicit(string? value) { }
}
}
namespace .
{
Expand Down
7 changes: 6 additions & 1 deletion TUnit.PublicAPI/Tests.Assertions_Library_Has_No_API_Changes.Net4_7.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ namespace
public static .<object?> That(.IEnumerable value, [.("value")] string? expression = null) { }
public static . That(<.> action, [.("action")] string? expression = null) { }
public static . That(. task, [.("task")] string? expression = null) { }
public static .<string> That(string? value, [.("value")] string? expression = null) { }
public static .<string> That(.StringValue value, [.("value")] string? expression = null) { }
public static .<TItem> That<TItem>(.<TItem>? value, [.("value")] string? expression = null) { }
public static .<TItem> That<TItem>(.<TItem>? value, [.("value")] string? expression = null) { }
public static .<TItem> That<TItem>(.<TItem>? value, [.("value")] string? expression = null) { }
Expand Down Expand Up @@ -213,6 +213,11 @@ namespace
public static .StringMatcher AsRegex(string pattern) { }
public static .StringMatcher AsWildcard(string pattern) { }
}
public readonly struct StringValue
{
public string? Value { get; }
public static .StringValue op_Implicit(string? value) { }
}
}
namespace .
{
Expand Down
Loading