-
Notifications
You must be signed in to change notification settings - Fork 958
feat: dynamic multiple edges in datapoints #1212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dynamic multiple edges in datapoints #1212
Conversation
Please make sure all the checkboxes are checked:
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis update introduces a major refactor and feature expansion for LLM structured output frameworks, including full integration of the BAML framework alongside existing Instructor/litellm support. A new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant API
participant Pipeline
participant LLMGateway
participant BAML/Instructor
User->>API: Submit data for processing (add/cognify)
API->>Pipeline: Start pipeline with incremental_loading
loop For each data item (concurrent)
Pipeline->>LLMGateway: Request structured output (e.g., extract graph/categories/summary)
alt Framework = BAML
LLMGateway->>BAML/Instructor: Route request to BAML extraction
else Framework = Instructor
LLMGateway->>BAML/Instructor: Route request to Instructor extraction
end
BAML/Instructor-->>LLMGateway: Structured output (graph, categories, etc.)
LLMGateway-->>Pipeline: Return structured output
Pipeline->>API: Update status, yield result/event
end
API-->>User: Return pipeline run info or error
sequenceDiagram
participant User
participant API
participant SearchModule
participant LLMGateway
User->>API: Search with type FEELING_LUCKY
API->>SearchModule: specific_search(query, FEELING_LUCKY)
SearchModule->>LLMGateway: select_search_type(query)
LLMGateway-->>SearchModule: Returns best SearchType
SearchModule->>SearchModule: Perform search with selected type
SearchModule-->>API: Return search results
API-->>User: Results
Estimated code review effort🎯 5 (Critical) | ⏱️ ~90+ minutes This PR introduces new frameworks, refactors core LLM and pipeline logic, adds new data models, and touches many files across the codebase, including generated and configuration files. Review will require careful attention to integration points, concurrency, error handling, and backward compatibility. Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
hajdul88
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me
Description
.indexlogic fromget_graph_from_model, transitioned to fully datapoint-oriented processing_datapoints_generatorwith nested loops[DataPoint, (Edge, DataPoint), (Edge, [DataPoint])], allowing dynamic multiple edges generationtest_get_graph_from_model_flexible_edges()covering weighted edges and dynamic multiple edgesdynamic_multiple_edges_example.pydemonstrating dynamic multiple edgesDCO Affirmation
I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.