-
Notifications
You must be signed in to change notification settings - Fork 1k
fix: graph visualization permissions #1219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: graph visualization permissions #1219
Conversation
<!-- .github/pull_request_template.md --> ## Description <!-- Provide a clear description of the changes in this PR --> ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.
…er optimization (topoteretes#1151) <!-- .github/pull_request_template.md --> ## Description feature: solve edge embedding duplicates in edge collection + retriever optimization ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin. --------- Co-authored-by: Vasilije <[email protected]>
…opoteretes#1092) <!-- .github/pull_request_template.md --> ## Description Attempt at making incremental loading run async ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.
<!-- .github/pull_request_template.md --> ## Description Add async lock for dynamic table creation ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.
…poteretes#1177) <!-- .github/pull_request_template.md --> ## Description Add default tokenizer for custom models not available on HuggingFace ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.
<!-- .github/pull_request_template.md --> ## Description <!-- Provide a clear description of the changes in this PR --> This PR implements the 'FEELING_LUCKY' search type, which intelligently routes user queries to the most appropriate search retriever, addressing [topoteretes#1162](topoteretes#1162). - implement new search type FEELING_LUCKY - Add the select_search_type function to analyze queries and choose the proper search type - Integrate with an LLM for intelligent search type determination - Add logging for the search type selection process - Support fallback to RAG_COMPLETION when the LLM selection fails - Add tests for the new search type ## How it works When a user selects the 'FEELING_LUCKY' search type, the system first sends their natural language query to an LLM-based classifier. This classifier analyzes the query's intent (e.g., is it asking for a relationship, a summary, or a factual answer?) and selects the optimal SearchType, such as 'INSIGHTS' or 'GRAPH_COMPLETION'. The main search function then proceeds using this dynamically selected type. If the classification process fails, it gracefully falls back to the default 'RAG_COMPLETION' type. ## Testing Tests can be run with: ```bash python -m pytest cognee/tests/unit/modules/search/search_methods_test.py -k "feeling_lucky" -v ``` ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin. Signed-off-by: EricXiao <[email protected]>
<!-- .github/pull_request_template.md --> ## Description <!-- Provide a clear description of the changes in this PR --> ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.
<!-- .github/pull_request_template.md --> ## Description Resolve issues with Cognee MCP docker use ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.
<!-- .github/pull_request_template.md --> ## Description <!-- Provide a clear description of the changes in this PR --> ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin. --------- Signed-off-by: Andrew Carbonetto <[email protected]> Signed-off-by: Andy Kwok <[email protected]> Co-authored-by: Vasilije <[email protected]> Co-authored-by: vasilije <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]> Co-authored-by: Andy Kwok <[email protected]>
<!-- .github/pull_request_template.md --> ## Description <!-- Provide a clear description of the changes in this PR --> ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.
<!-- .github/pull_request_template.md --> ## Description <!-- Provide a clear description of the changes in this PR --> ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.
<!-- .github/pull_request_template.md --> ## Description <!-- Provide a clear description of the changes in this PR --> ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin. --------- Signed-off-by: Raj2604 <[email protected]> Co-authored-by: Daulet Amirkhanov <[email protected]> Co-authored-by: Hande <[email protected]> Co-authored-by: Igor Ilic <[email protected]> Co-authored-by: Igor Ilic <[email protected]> Co-authored-by: Boris <[email protected]> Co-authored-by: Matea Pesic <[email protected]> Co-authored-by: github-actions[bot] <[email protected]> Co-authored-by: hajdul88 <[email protected]> Co-authored-by: Boris Arzentar <[email protected]> Co-authored-by: Raj Mandhare <[email protected]> Co-authored-by: Pedro Thompson <[email protected]> Co-authored-by: Pedro Henrique Thompson Furtado <[email protected]>
<!-- .github/pull_request_template.md --> ## Description Add multi db support for Neo4j Enterprise users ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin. --------- Signed-off-by: Raj2604 <[email protected]> Co-authored-by: vasilije <[email protected]> Co-authored-by: Vasilije <[email protected]> Co-authored-by: Daulet Amirkhanov <[email protected]> Co-authored-by: Hande <[email protected]> Co-authored-by: Boris <[email protected]> Co-authored-by: Matea Pesic <[email protected]> Co-authored-by: github-actions[bot] <[email protected]> Co-authored-by: hajdul88 <[email protected]> Co-authored-by: Boris Arzentar <[email protected]> Co-authored-by: Raj Mandhare <[email protected]> Co-authored-by: Pedro Thompson <[email protected]> Co-authored-by: Pedro Henrique Thompson Furtado <[email protected]>
This will allow to deal with the issue when the user is using custom embedding and LLM and passes the hosted_vllm option as part of the LiteLLM documentation <!-- .github/pull_request_template.md --> ## Description <!-- This allows the user to use hosted_vllm with respect to LiteLLM usage - and only gets applicable for custom embedding models - specifically Hugging Face models --> ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.
…sh (topoteretes#1210) <!-- .github/pull_request_template.md --> ## Description Changing deletion logic to use document id instead of content hash ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.
<!-- .github/pull_request_template.md --> ## Description <!-- Provide a clear description of the changes in this PR --> - Improved list handling, removed `.index` logic from `get_graph_from_model`, transitioned to fully datapoint-oriented processing - Streamlined datapoint iteration by introducing `_datapoints_generator` with nested loops - Generalized field processing to handle mixed lists: `[DataPoint, (Edge, DataPoint), (Edge, [DataPoint])]`, allowing dynamic multiple edges generation - Small improvements and refactorings - Added tests to `test_get_graph_from_model_flexible_edges()` covering weighted edges and dynamic multiple edges - Created `dynamic_multiple_edges_example.py` demonstrating dynamic multiple edges ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.
Signed-off-by: EricXiao <[email protected]>
Please make sure all the checkboxes are checked:
|
|
Caution Review failedThe pull request is closed. WalkthroughThis update introduces extensive support for structured output frameworks, notably integrating the BAML client and instructor-based LLM gateway, and refactors LLM-related logic to use a new LLMGateway abstraction. It also implements incremental data loading in pipelines, adds permission-aware dataset access, introduces new data models, and updates search type selection with a "feeling lucky" mode. Changes
Sequence Diagram(s)sequenceDiagram
participant API
participant LLMGateway
participant BAMLClient
participant InstructorClient
API->>LLMGateway: extract_content_graph(content, response_model, mode)
alt framework == "BAML"
LLMGateway->>BAMLClient: ExtractContentGraphGeneric(content, mode)
BAMLClient-->>LLMGateway: KnowledgeGraph
else framework == "instructor"
LLMGateway->>InstructorClient: acreate_structured_output(content, prompt, response_model)
InstructorClient-->>LLMGateway: KnowledgeGraph
end
LLMGateway-->>API: KnowledgeGraph
sequenceDiagram
participant User
participant API
participant Pipeline
participant DB
User->>API: POST /add (incremental_loading=True)
API->>Pipeline: cognee_pipeline(..., incremental_loading=True)
Pipeline->>DB: Check data item status
alt Already processed
Pipeline-->>API: PipelineRunAlreadyCompleted
else Not processed
Pipeline->>DB: Process and update status
Pipeline-->>API: PipelineRunCompleted
end
Estimated code review effort🎯 5 (Critical) | ⏱️ ~90+ minutes Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Description
This PR fix graph visualization access for users with read permissions (#1182)
Testing
Tests can be run with:
DCO Affirmation
I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.