docs: add links to other language versions of README #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- .github/pull_request_template.md --> ## Description <!-- Provide a clear description of the changes in this PR --> ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin. --------- Signed-off-by: Diego B Theuerkauf <[email protected]> Co-authored-by: vasilije <[email protected]> Co-authored-by: Igor Ilic <[email protected]> Co-authored-by: Vasilije <[email protected]> Co-authored-by: Igor Ilic <[email protected]> Co-authored-by: Hande <[email protected]> Co-authored-by: Matea Pesic <[email protected]> Co-authored-by: hajdul88 <[email protected]> Co-authored-by: Daniel Molnar <[email protected]> Co-authored-by: Diego Baptista Theuerkauf <[email protected]> Co-authored-by: Dmitrii Galkin <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: lxobr <[email protected]> Co-authored-by: github-actions[bot] <[email protected]>
<!-- .github/pull_request_template.md --> ## Description Update migration example for upcoming blog on main branch ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.
<!-- .github/pull_request_template.md --> ## Description <!-- Provide a clear description of the changes in this PR --> ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.
<!-- .github/pull_request_template.md --> ## Description <!-- Provide a clear description of the changes in this PR --> ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.
…#906) <!-- .github/pull_request_template.md --> ## Description <!-- Provide a clear description of the changes in this PR --> ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.
<!-- .github/pull_request_template.md --> ## Description Resolve user already exist issue for UI ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin. --------- Co-authored-by: Boris Arzentar <[email protected]>
<!-- .github/pull_request_template.md --> ## Description <!-- Provide a clear description of the changes in this PR --> ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.
<!-- .github/pull_request_template.md --> ## Description <!-- Provide a clear description of the changes in this PR --> ## DCO Affirmation I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.
Added language selection links to the README for easier access to translated versions: Chinese, Russian, Spanish, Japanese, French, Portuguese, German, and Korean.
Please make sure all the checkboxes are checked:
|
Contributor
WalkthroughThe "Available Languages" section in the README.md was updated to use external links from readme-i18n.com for multiple languages, replacing local markdown file links. The language list was expanded, formatting changed to use pipes, and language names are now in their native scripts or names. Changes
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
README.md (2)
40-47: Optional: Addtarget="_blank"andrel="noopener noreferrer"to external links.
Opening translations in a new tab improves UX and prevents potential security issues withwindow.opener.
42-42: Nit: Capitalize "français" for consistency.
Other language names start with a capital letter—consider updating this entry toFrançais.
Comment on lines
+40
to
+47
| <a href="https://www.readme-i18n.com/topoteretes/cognee?lang=de">Deutsch</a> | | ||
| <a href="https://www.readme-i18n.com/topoteretes/cognee?lang=es">Español</a> | | ||
| <a href="https://www.readme-i18n.com/topoteretes/cognee?lang=fr">français</a> | | ||
| <a href="https://www.readme-i18n.com/topoteretes/cognee?lang=ja">日本語</a> | | ||
| <a href="https://www.readme-i18n.com/topoteretes/cognee?lang=ko">한국어</a> | | ||
| <a href="https://www.readme-i18n.com/topoteretes/cognee?lang=pt">Português</a> | | ||
| <a href="https://www.readme-i18n.com/topoteretes/cognee?lang=ru">Русский</a> | | ||
| <a href="https://www.readme-i18n.com/topoteretes/cognee?lang=zh">中文</a> |
Contributor
There was a problem hiding this comment.
💡 Verification agent
❓ Verification inconclusive
Verify external translation links.
Ensure each https://www.readme-i18n.com/topoteretes/cognee?lang=<code> URL returns HTTP 200 and serves the correct language.
🏁 Script executed:
#!/usr/bin/env bash
# Check that all language links resolve successfully
for lang in de es fr ja ko pt ru zh; do
status=$(curl -s -o /dev/null -w '%{http_code}' "https://www.readme-i18n.com/topoteretes/cognee?lang=$lang")
if [ "$status" -ne 200 ]; then
echo "Link for $lang returned HTTP $status"
fi
doneLength of output: 1375
🏁 Script executed:
#!/usr/bin/env bash
# Verify that each translation page sets the correct HTML lang attribute
for lang in de es fr ja ko pt ru zh; do
url="https://www.readme-i18n.com/topoteretes/cognee?lang=$lang"
content=$(curl -s "$url")
if ! echo "$content" | grep -E '<html[^>]*lang="'"$lang"'"' >/dev/null; then
echo "Expected html lang=\"$lang\" not found at $url"
fi
doneLength of output: 85020
Fix missing HTML lang attributes on translated README pages
Verification shows that while each translation link returns HTTP 200, the served pages still use <html lang="en"> for all languages instead of their respective codes (de, es, fr, etc.). This should be updated to improve accessibility and SEO.
• Affected URLs (lines 40–47 in README.md):
- https://www.readme-i18n.com/topoteretes/cognee?lang=de
- https://www.readme-i18n.com/topoteretes/cognee?lang=es
- …
- https://www.readme-i18n.com/topoteretes/cognee?lang=zh
Suggested fix:
Ensure the server-side renderer or language switch logic injects the correct lang attribute, e.g.:
- <html lang="en" class="dark">
+ <html lang="{{ userLang }}" class="dark">Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In README.md lines 40 to 47, the external translation links point to pages that
all use <html lang="en"> instead of their respective language codes, which harms
accessibility and SEO. To fix this, update the server-side rendering or language
switch logic that generates these translated pages to dynamically set the <html>
tag's lang attribute to the correct language code based on the lang query
parameter in the URL. Verify that each translated page's HTML root element uses
the appropriate lang attribute matching the language code in the URL.
Contributor
|
closing, opens up too many changes. please open a PR with only suggested ones |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added language selection links to the README for easier access to translated versions: Chinese, Russian, Spanish, Japanese, French, Portuguese, German, and Korean.
Description
DCO Affirmation
I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.