Drop P parameter from backend and extension traits #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
approved these changes
Feb 8, 2023
The Backend, Dispatch, ExtensionImpl and ExtensionDispatch traits don’t need to have the platform as a type parameter P. It is sufficient if the request handling methods receive it as a type parameter. This makes it easier to implement the traits.
robin-nitrokey
force-pushed
the
dispatch
branch
from
8e36ca8 to
02b5b7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Backend, Dispatch, ExtensionImpl and ExtensionDispatch traits don’t need to have the platform as a type parameter P. It is sufficient if the request handling methods receive it as a type parameter. This makes it easier to implement the traits.