Align SoftDelete logic with Model::preventAccessingMissingAttributes() #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed an issue in commit 4b76635 where a logic was introduced to handle the
deleted_atcolumn.However, in my project, the native Laravel's sanity check was enabled in my
AppServiceProviderviaModel::preventAccessingMissingAttributes(), as described in this article: https://planetscale.com/blog/laravels-safety-mechanisms.As a result, the
TypesenseEngine.phpattempts to access thedeleted_atproperty, which may not be present on the model if theSoftDeletestrait is not used on model class.This results in an
Illuminate\Database\Eloquent\MissingAttributeExceptionwith the following message:Change Summary
I have addressed this issue by adding an additional check, which resolved the problem. Please review my pull request.
PR Checklist