Handle NewClassTree in compareGenericTypeParameterNullabilityForCall(#1212)#1217
Merged
msridhar merged 4 commits intouber:masterfrom Jun 4, 2025
Merged
Handle NewClassTree in compareGenericTypeParameterNullabilityForCall(#1212)#1217msridhar merged 4 commits intouber:masterfrom
msridhar merged 4 commits intouber:masterfrom
Conversation
…icTypeParameterNullabilityForCall(uber#1212)
msridhar
reviewed
Jun 4, 2025
Collaborator
msridhar
left a comment
msridhar
left a comment
There was a problem hiding this comment.
Looks good! Let's just add one comment
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1217 +/- ##
=========================================
Coverage 88.29% 88.30%
- Complexity 2351 2353 +2
=========================================
Files 89 89
Lines 7657 7662 +5
Branches 1533 1535 +2
=========================================
+ Hits 6761 6766 +5
Misses 450 450
Partials 446 446 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Manu Sridharan <msridhar@gmail.com>
msridhar
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle NewClassTree for constructor type substitution in compareGenericTypeParameterNullabilityForCall.
Addresses part of #1212