Skip to content

Handle NewClassTree in compareGenericTypeParameterNullabilityForCall(#1212) #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msridhar merged 4 commits into from
Jun 4, 2025
+41 −0
Merged

Handle NewClassTree in compareGenericTypeParameterNullabilityForCall(#1212) #1217

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71e1cd9
test case
msridhar May 10, 2025
3e00399
Handle NewClassTree for constructor type substitution in compareGener…
dhruv-agr May 27, 2025
1a3697a
Merge branch 'master' into issue-1212-1
msridhar Jun 4, 2025
e7d9959
added a comment in fix for #1212
dhruv-agr Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
added a comment in fix for #1212 
Co-authored-by: Manu Sridharan <msridhar@gmail.com>
  • Loading branch information
@dhruv-agr @msridhar
dhruv-agr and msridhar authored Jun 4, 2025
commit e7d99599ef8b5b6870f9f47013e2883ab71f84d9
1 change: 1 addition & 0 deletions nullaway/src/main/java/com/uber/nullaway/generics/GenericsChecks.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,6 +703,7 @@ public void compareGenericTypeParameterNullabilityForCall(

// substitute type arguments for constructor call
if (tree instanceof NewClassTree) {
// get the type arguments from the NewClassTree itself
Type enclosingType = getTreeType(tree, config);
Comment thread
dhruv-agr marked this conversation as resolved.
if (enclosingType != null) {
invokedMethodType =
Expand Down