Skip to content

Conversation

@matt-oakes
Copy link

Hi,

I was having a problem when I was using SlidingUpPanelLayout inside a DrawerLayout. If you started dragging the panel up and then moved your finger slightly either left or right the DrawerPanel would take over and start moving the drawer left and right.

The solution was to call requestDisallowInterceptTouchEvent inside onInterceptTouchEvent with the value we are going to return. Therefore we will still allow the drawer to intercept if we don't want it, but we will effectively lock the drawer if we've decided the user has started dragging the SlidingUpPanel.

Let me know if there are any changes which need to be made.

Matt

@matt-oakes
Copy link
Author

Just noticed this was still here. Is it worth me rebasing it?

@tokudu
Copy link
Contributor

tokudu commented Oct 13, 2014

Hi Matt, apologizes - I haven't had time to look at this. Please rebase if you could and if the issue is still there. Thank you for contributing!

@matt-oakes matt-oakes force-pushed the fix_parent_intercept branch from 0b7b1f1 to f1ee8e1 Compare October 13, 2014 17:14
@matt-oakes
Copy link
Author

I've rebased. I've not tested it, but the code should still work as before 😄

@pvllnspk
Copy link

pvllnspk commented Nov 5, 2014

I've faced the same problem when using SlidingUpPanel on MapFragment. This problem is still actual and it occurs always. Steps to reproduced are the same like described above. After that onInterceptTouchEvent always returns true.

@matt-oakes
Copy link
Author

@pvllnspk Can you check if my rebased pull request branch fixes this issue still? If it does fix it you should be able to merge it @tokudu 👍

@pvllnspk
Copy link

pvllnspk commented Nov 5, 2014

No, problem is still reproduced.

@gautamverma
Copy link

So how to use the SlidingUp Panel Drawer together?

What i want is Left drawer comes over the SlidingPanel.

I tried

  1. Making the SlidingPanel a child of the DrawerLayout then the panel won't drag up. It would just remain stick to base.

  2. Move the whole SlidingPanel to a fragment then also the same problem.

  3. If i make the drawer layout the child of SlidingPanel then it always remains below it.

Any ideas??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants