Skip to content

Fixed parents overriding touch intercepts (SlidingUpPanel inside DrawerLayout) #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matt-oakes wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed parents overriding touch intercepts (SlidingUpPanel inside DrawerLayout) #97

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48028a8
The slideup past notification drawer
Jan 15, 2014
3ee7160
Fixed a bug in SlidingUpPaneLayout where the parent (DrawerLayout for…
Jan 17, 2014
f1ee8e1
Removed ant build files for pull request
Jan 17, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed a bug in SlidingUpPaneLayout where the parent (DrawerLayout for… 
… example) would still attempt to intercept touch events when dragging the drag view
  • Loading branch information
@matt-oakes
Matt Oakes authored and matt-oakes committed Oct 13, 2014
commit 3ee7160fc47bb81ef51a94f70d26e43bf9dcfd1b
10 changes: 9 additions & 1 deletion library/src/com/sothree/slidinguppanel/SlidingUpPanelLayout.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import android.view.View;
import android.view.ViewGroup;
import android.view.accessibility.AccessibilityEvent;
import android.view.ViewParent;

import com.nineoldandroids.view.animation.AnimatorProxy;
import com.sothree.slidinguppanel.library.R;
Expand Down Expand Up @@ -777,7 +778,14 @@ public boolean onInterceptTouchEvent(MotionEvent ev) {
}
}

return mDragHelper.shouldInterceptTouchEvent(ev);
final boolean shouldInterceptTouchEvent = mDragHelper.shouldInterceptTouchEvent(ev);

ViewParent parent = getParent();
if (parent != null) {
parent.requestDisallowInterceptTouchEvent(shouldInterceptTouchEvent);
}

return shouldInterceptTouchEvent;
}

@Override
Expand Down