Skip to content

Conversation

@logansnow17
Copy link
Collaborator

@logansnow17 logansnow17 commented Jul 14, 2025

Description

https://uncount.atlassian.net/browse/MAT-53977

Request to pad the hours and minutes with a zero like most standard time controls.

image
nvm install 16
nvm use 16
npm run playground

Tested in the browser tab that opens

Low risk for now, will also be tested on PR in main which will be higher risk as this is a common style control. Be sure to test that editing works as expected

Also please test that the generated build is up to date. i.e. if you run npm run build there are no changed files.

@logansnow17 logansnow17 assigned leb2 and ihuang8 and unassigned leb2 Jul 14, 2025
return constraints;
}

export const IntegerInput = ({value, onChange, min, max}) => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't need to be exported

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, checked that this only gets used in the current file

@grace-uncountable
Copy link

hm it looks like the playground is a bit buggy on my end, but I think these changes are correct -- it makes sense to be padding up to 2 numbers here. Before approving, I just had a quick question:

Low risk for now, will also be tested on PR in main which will be higher risk as this is a common style control. Be sure to test that editing works as expected

does this just mean that after we push this build, you're going to follow up in the main repo with a separate PR that actually upgrades the version we're using?

@logansnow17
Copy link
Collaborator Author

hm it looks like the playground is a bit buggy on my end, but I think these changes are correct -- it makes sense to be padding up to 2 numbers here. Before approving, I just had a quick question:

Low risk for now, will also be tested on PR in main which will be higher risk as this is a common style control. Be sure to test that editing works as expected

does this just mean that after we push this build, you're going to follow up in the main repo with a separate PR that actually upgrades the version we're using?

Correct yeah, the next PR will be on the main repo and just bump the package version

Copy link

@grace-uncountable grace-uncountable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks for working on this

@logansnow17 logansnow17 merged commit 567c295 into master Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants