-
Notifications
You must be signed in to change notification settings - Fork 0
add padding #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add padding #9
Conversation
| return constraints; | ||
| } | ||
|
|
||
| export const IntegerInput = ({value, onChange, min, max}) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't need to be exported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense, checked that this only gets used in the current file
|
hm it looks like the playground is a bit buggy on my end, but I think these changes are correct -- it makes sense to be padding up to 2 numbers here. Before approving, I just had a quick question:
does this just mean that after we push this build, you're going to follow up in the main repo with a separate PR that actually upgrades the version we're using? |
Correct yeah, the next PR will be on the main repo and just bump the package version |
grace-uncountable
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, thanks for working on this
Description
https://uncount.atlassian.net/browse/MAT-53977
Request to pad the hours and minutes with a zero like most standard time controls.
Tested in the browser tab that opens
Low risk for now, will also be tested on PR in main which will be higher risk as this is a common style control. Be sure to test that editing works as expected
Also please test that the generated build is up to date. i.e. if you run
npm run buildthere are no changed files.