Skip to content

add padding #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 14, 2025
Merged

add padding #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1ea5b78
add padding
logansnow17 Jul 14, 2025
b7db32d
bump
logansnow17 Jul 14, 2025
89a8c76
build
logansnow17 Jul 14, 2025
c9e713b
maxlength
logansnow17 Jul 14, 2025
9040f36
revert maxlength
logansnow17 Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/react-datetime.cjs.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/react-datetime.cjs.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/react-datetime.umd.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/react-datetime.umd.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-datetime",
"version": "3.1.0-unc-8",
"version": "3.1.0-unc-9",
"description": "A lightweight but complete datetime picker React.js component",
"homepage": "https://github.com/arqex/react-datetime",
"repository": {
Expand Down
6 changes: 4 additions & 2 deletions src/views/TimeView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ function createConstraints( overrideTimeConstraints ) {
return constraints;
}

export const IntegerInput = ({value, onChange, min, max}) => {
Copy link
Collaborator Author

@logansnow17 logansnow17 Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't need to be exported

Copy link

@grace-uncountable grace-uncountable Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, checked that this only gets used in the current file

const IntegerInput = ({value, onChange, min, max}) => {
const [stateValue, setStateValue] = useState(value);
const invalid = parseInt(stateValue, 10) !== parseInt(value, 10);

Expand All @@ -53,9 +53,11 @@ export const IntegerInput = ({value, onChange, min, max}) => {
}
}, [onChange, max, min, setStateValue]);

const displayValue = String(stateValue).padStart(2, '0');

return (
<input
value={stateValue}
value={displayValue}
onChange={onChangeCallback}
className={`rdtInput ${invalid && 'invalid'}`}
/>
Expand Down