remove unstable runtime setting from call_runtime example docs #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agryaznov
changed the title
ascjones
approved these changes
May 31, 2023
pgherveou
reviewed
May 31, 2023
| … | ||
| // `Everything` or anything that will allow for the `Balances::transfer` extrinsic. | ||
| type CallFilter = frame_support::traits::Everything; | ||
| type UnsafeUnstableInterface = ConstBool<true>; |
Contributor
There was a problem hiding this comment.
we should probably keep it and specify for version of pallet-contract < xxx
Contributor
Author
There was a problem hiding this comment.
well, it's just an example of a runtime configuration, imo it should just work with current master
we don't want to keep these nuances for each stabilized host function, right?
Contributor
There was a problem hiding this comment.
mm I am pretty sure that a lot of people will run this against the contract-node that is only updated at every release
Contributor
Author
There was a problem hiding this comment.
I updated it yesterday
pgherveou
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
once call_runtime is stabilized use-ink/ink#1749, we don't need the
UnsafeUnstableInterface